Added samples, benchmarks and docs for nox format. #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
VachaShah,
harshavamsi,
axeoman,
deztructor,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
dblock
force-pushed
the
format-samples
branch
from
104b5f3 to
8159aec
Compare
Codecov Report
@@ Coverage Diff @@
## main #556 +/- ##
=======================================
Coverage 71.10% 71.10%
=======================================
Files 85 85
Lines 7774 7774
=======================================
Hits 5528 5528
Misses 2246 2246 |
VachaShah
reviewed
Oct 26, 2023
samples/bulk/bulk-array.py
Outdated
| # compatible open source license. | ||
| # | ||
| # Modifications Copyright OpenSearch Contributors. See | ||
| # GitHub history for details. | ||
|
|
||
| # SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
The files have this part of the license already.
There was a problem hiding this comment.
Fixed. I also made the checking code quite a bit simpler.
dblock
force-pushed
the
format-samples
branch
2 times, most recently
from
450c5f4 to
65e4484
Compare
Signed-off-by: dblock <[email protected]>
dblock
force-pushed
the
format-samples
branch
from
65e4484 to
68c89de
Compare
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
dblock
changed the title
VachaShah
approved these changes
Oct 26, 2023
saimedhi
approved these changes
Oct 27, 2023
roma2023
pushed a commit
to roma2023/opensearch-py
that referenced
this pull request
Dec 28, 2023
…t#556) * Added samples for nox format. Signed-off-by: dblock <[email protected]> * Added space after #!/usr/bin/env python. Signed-off-by: dblock <[email protected]> * Added benchmarks and docs. Signed-off-by: dblock <[email protected]> --------- Signed-off-by: dblock <[email protected]> Signed-off-by: roma2023 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added samples, benchmarks and docs for nox format.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.