Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate cluster client from API specs #530

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

saimedhi
Copy link
Collaborator

@saimedhi saimedhi commented Oct 9, 2023

Description

Generate cluster client from API specs

Issues Resolved

related to #477

cluster.health - ensure_node_commissioned param should not be present

  • need to be corrected in spec.

https://localhost:9200/_cluster/health?ensure_node_commissioned=true
{
"error": {
"root_cause": [
{
"type": "illegal_argument_exception",
"reason": "request [/_cluster/health] contains unrecognized parameter: [ensure_node_commissioned] -> did you mean [ensure_node_weighed_in]?"
}
],
"type": "illegal_argument_exception",
"reason": "request [/_cluster/health] contains unrecognized parameter: [ensure_node_commissioned] -> did you mean [ensure_node_weighed_in]?"
},
"status": 400
}
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #530 (a1824f3) into main (e4c59e4) will decrease coverage by 0.12%.
The diff coverage is 53.12%.

@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
- Coverage   70.80%   70.69%   -0.12%     
==========================================
  Files          83       83              
  Lines        7790     7844      +54     
==========================================
+ Hits         5516     5545      +29     
- Misses       2274     2299      +25     
Files Coverage Δ
opensearchpy/_async/client/cluster.py 51.76% <53.12%> (-3.41%) ⬇️
opensearchpy/client/cluster.py 56.47% <53.12%> (-5.60%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to generate all remaining APIs in one go?

@dblock
Copy link
Member

dblock commented Oct 9, 2023

need to be corrected in spec

Are you doing this? Opening issues?

@dblock dblock merged commit ce835fb into opensearch-project:main Oct 9, 2023
59 of 61 checks passed
@saimedhi
Copy link
Collaborator Author

saimedhi commented Oct 9, 2023

Opening issues?

yes, I am opening issues in opensearch-api-specification repo

@saimedhi
Copy link
Collaborator Author

saimedhi commented Oct 9, 2023

Any reason not to generate all remaining APIs in one go?

I can generate all at once, but it'll be easier to spot small issues or mistakes in the generated client with smaller PRs.

Djcarrillo6 added a commit to Djcarrillo6/opensearch-py that referenced this pull request Oct 14, 2023
Signed-off-by: Djcarrillo6 <[email protected]>

Updated CHANGELOG

Signed-off-by: Djcarrillo6 <[email protected]>

Updated CHANGELOG & link to sample.

Signed-off-by: Djcarrillo6 <[email protected]>

updated changelog (opensearch-project#522)

Signed-off-by: saimedhi <[email protected]>

Bump version to 2.3.2 (opensearch-project#524)

Signed-off-by: saimedhi <[email protected]>

Fix: typos. (opensearch-project#526)

* Fix: typo.

Signed-off-by: dblock <[email protected]>

* Fix: typo.

Signed-off-by: dblock <[email protected]>

* Fixed its.

Signed-off-by: dblock <[email protected]>

* Added Visual Code settings to .gitignore.

Signed-off-by: dblock <[email protected]>

* Added loop type for async client.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>

Modified generator to generate api deprecation warnings (opensearch-project#527)

Signed-off-by: saimedhi <[email protected]>

Generate cat client from API specs (opensearch-project#529)

Signed-off-by: saimedhi <[email protected]>

Generate cluster client from API specs (opensearch-project#530)

Signed-off-by: saimedhi <[email protected]>

Added new guide & sample module for using index templates. (opensearch-project#531)

Added index_template guide and sample

Signed-off-by: Djcarrillo6 <[email protected]>

Removed EOL Python3.5 & bumped urllib3 version to patch security vulnerability (opensearch-project#533)

Updated CHANGELOG with pull #

Updated CHANGELOG with pull #

Updated CHANGELOG removed section.

Updated CHANGELOG removed section again

Signed-off-by: Djcarrillo6 <[email protected]>

Align pool_maxsize for different connection pool implementations. (opensearch-project#535)

* Align pool_maxsize for different connection pool implementations.

Signed-off-by: dblock <[email protected]>

* Document connection classes and settings.

Signed-off-by: dblock <[email protected]>

* Undo change in async for backwards compatibility.

Signed-off-by: dblock <[email protected]>

* Fix: typo.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>

Add micro benchmarks. (opensearch-project#537)

* Align pool_maxsize for different connection pool implementations.

Signed-off-by: dblock <[email protected]>

* Added benchmarks.

Signed-off-by: dblock <[email protected]>

* Multi-threaded vs. async benchmarks.

Signed-off-by: dblock <[email protected]>

* Set pool size to the number of threads.

Signed-off-by: dblock <[email protected]>

* Added sync/async benchmark.

Signed-off-by: dblock <[email protected]>

* Report client-side latency.

Signed-off-by: dblock <[email protected]>

* Various updates to benchmarks, demonstrating threading improves throughput.

Signed-off-by: dblock <[email protected]>

* Bench info.

Signed-off-by: dblock <[email protected]>

* Fixup format.

Signed-off-by: dblock <[email protected]>

* Undo async maxsize.

Signed-off-by: dblock <[email protected]>

* Moved benchmarks folder.

Signed-off-by: dblock <[email protected]>

* Updated documentation and project description.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>
@saimedhi saimedhi deleted the merge/cluster_client branch December 14, 2023 20:30
roma2023 pushed a commit to roma2023/opensearch-py that referenced this pull request Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants