feat: Add a collapse method to opensearchpy.helpers.search.Search
#409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qcoumes
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor and
Shephalimittal
as code owners
saimedhi
reviewed
Jun 12, 2023
dblock
reviewed
Jun 20, 2023
Signed-off-by: Quentin Coumes <[email protected]>
|
I resolved the conflict. I don't know where I should add some documentation in the user guide. The Using DSL features from opensearch-dsl-py chapter is mainly a redirection to It seems weird to have a subchapter about |
Yes, you're of course right. Would love someone (hint hint) to contribute some basic features doc. I'll let it slide for this PR :) Thank you! |
dblock
previously approved these changes
Jun 26, 2023
Codecov Report
@@ Coverage Diff @@
## main #409 +/- ##
==========================================
+ Coverage 71.66% 71.72% +0.05%
==========================================
Files 77 77
Lines 7190 7204 +14
==========================================
+ Hits 5153 5167 +14
Misses 2037 2037
|
Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>
dblock
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
collapsemethod toopensearchpy.helpers.search.Searchwhich allows adding acollapserequirement to a query without the need of.extra().This is achieved similarly to how
sort()is done.Issues Resolved
#408