Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced existing API generator to use the OpenAPI spec as the input format #376

Closed
wants to merge 36 commits into from

Conversation

saimedhi
Copy link
Collaborator

Description

Enhanced existing API generator to use the OpenAPI spec as the input format

Issues Resolved

Closes #348

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

Merging #376 (88b97a6) into main (83be2cd) will increase coverage by 1.28%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
+ Coverage   70.72%   72.01%   +1.28%     
==========================================
  Files          77       77              
  Lines        7157     7190      +33     
==========================================
+ Hits         5062     5178     +116     
+ Misses       2095     2012      -83     

see 29 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: saimedhi <[email protected]>
Copy link
Collaborator

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @saimedhi!

For the implementation of the generator, lets not add the specs to the client. The generator should use the specs from the opensearch-api-specification repo. See opensearch-project/opensearch-api-specification#74

@dblock
Copy link
Member

dblock commented Apr 25, 2023

+1 for not checking in spec files and importing them, otherwise looks good!

@nhtruong
Copy link
Contributor

@VachaShah The OpenAPI specs on opensearch-api-specification repo currently doesn't have the extra metadata needed for generate the client code. This PR and its follow-up will have to be merged first before we can use the specs there for client generation.

@saimedhi saimedhi closed this Jun 15, 2023
@saimedhi saimedhi deleted the fix/api-generator branch October 4, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Enhance the existing code generator to use the OpenAPI spec as the input format
5 participants