Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload SBOM to release artifacts #1234

Merged

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Jan 16, 2025

Description

Upload SBOM to release

Issues Resolved

Currently SBOM are published to release run artifacts, but not release https://github.com/opensearch-project/opensearch-migrations/actions/runs/12717975529

Testing

Verified on my fork using a modified version of the workflow
https://github.com/AndreKurait/opensearch-migrations/actions/runs/12837665875/job/35802627618

Check List

  • New functionality includes testing
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AndreKurait AndreKurait marked this pull request as ready for review January 16, 2025 16:13
@AndreKurait AndreKurait force-pushed the upload-attribution-release branch from 21c39da to fd31f15 Compare January 16, 2025 16:15
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.39%. Comparing base (9781a9b) to head (8cf33ee).
Report is 69 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1234      +/-   ##
============================================
- Coverage     80.59%   80.39%   -0.21%     
- Complexity     3079     3094      +15     
============================================
  Files           421      424       +3     
  Lines         15658    15742      +84     
  Branches       1057     1066       +9     
============================================
+ Hits          12619    12655      +36     
- Misses         2395     2435      +40     
- Partials        644      652       +8     
Flag Coverage Δ
unittests 80.39% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreKurait AndreKurait force-pushed the upload-attribution-release branch from fd31f15 to 16bdbc8 Compare January 18, 2025 14:43
@AndreKurait AndreKurait changed the title Upload SBOM to release Fix upload SBOM to release artifacts Jan 18, 2025
Signed-off-by: Andre Kurait <[email protected]>
@AndreKurait AndreKurait force-pushed the upload-attribution-release branch from 16bdbc8 to 8cf33ee Compare January 18, 2025 14:45
@AndreKurait AndreKurait merged commit 1338c66 into opensearch-project:main Jan 21, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants