PR feedback

Signed-off-by: Peter Nied <[email protected]>
opensearch-project · Dec 3, 2024 · ae672d2 · ae672d2
1 parent b0703ed
commit ae672d2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/MetadataMigration/DEVELOPER_GUIDE.md b/MetadataMigration/DEVELOPER_GUIDE.md
@@ -71,7 +71,7 @@ If your target cluster has basic auth enabled on it, you can supply those creden
 
 ### Allowlisting the templates and indices to migrate
 
-By default, allowlist for indices and index templates is open, meaning all non-system indices (those not prefixed with `.`) will be migrated.  You can tweak these allowlists with a comma-separated list of items you specifically with to migrate.  If you specify an custom allowlist for the templates or indices, the default allowlist is disregarded and **only** the items you have in your allowlist will be moved.
+By default, allowlist for indices and all templates types is open, meaning all non-system indices (those not prefixed with `.`) will be migrated.  You can tweak these allowlists with a comma-separated list of items you specifically with to migrate.  If you specify an custom allowlist for the templates or indices, the default allowlist is disregarded and **only** the items you have in your allowlist will be moved.
 
 ```shell
 ./gradlew MetadataMigration:run --args='--snapshot-name reindex-from-snapshot --s3-local-dir /tmp/s3_files --s3-repo-uri s3://your-s3-uri --s3-region us-fake-1 --target-host http://hostname:9200 --index-allowlist Index1,.my_system_index,logs-2023 --index-template-allowlist logs_template --component-template-allowlist component2,component7'

diff --git a/...ava/org/opensearch/migrations/bulkload/version_os_2_11/GlobalMetadataCreator_OS_2_11.java b/...ava/org/opensearch/migrations/bulkload/version_os_2_11/GlobalMetadataCreator_OS_2_11.java
@@ -149,7 +149,7 @@ private List<CreationResult> processTemplateCreation(
             var creationResult = CreationResult.builder().name(templateName);
 
             if (skipCreation.test(templateName)) {
-                log.atInfo().setMessage("Template {} was skipped due to allow list filter {}").addArgument(templateName).addArgument(templateAllowList).log();
+                log.atInfo().setMessage("Template {} was skipped due to allowlist filter {}").addArgument(templateName).addArgument(templateAllowList).log();
                 return creationResult.failureType(CreationFailureType.SKIPPED_DUE_TO_FILTER).build();
             }
 

diff --git a/RFS/src/main/java/org/opensearch/migrations/bulkload/worker/IndexRunner.java b/RFS/src/main/java/org/opensearch/migrations/bulkload/worker/IndexRunner.java
@@ -36,7 +36,7 @@ public IndexMetadataResults migrateIndices(MigrationMode mode, ICreateIndexConte
                 CreationResult creationResult;
                 if (skipCreation.test(index.getName())) {
                     log.atInfo()
-                        .setMessage("Index {} was not part of the allow list and will not be migrated.")
+                        .setMessage("Index {} was not part of the allowlist and will not be migrated.")
                         .addArgument(index.getName())
                         .log();
                     creationResult = CreationResult.builder()