Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support component name filter for release metrics #67

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

prudhvigodithi
Copy link
Member

Description

Support component name for release metrics. This should be able to help user filter the documents with repo name or component name. In the following example find the result either by anomaly-detection-dashboards-plugin or by anomalyDetectionDashboards should yield the same results.

 "_source": {
    "release_issue_exists": true,
    "release_notes": false,
    "version_increment": true,
    "release_issue": "https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/issues/802",
    "autocut_issues_open": 0,
    "repository": "anomaly-detection-dashboards-plugin",
    "release_state": "closed",
    "version": "2.15.0",
    "pulls_open": 0,
    "release_owner_exists": false,
    "current_date": "2024-08-26T21:25:20.901042281",
    "component": "anomalyDetectionDashboards",
    "release_branch": true,
    "issues_closed": 5,
    "pulls_closed": 5,
    "id": "1c8b312c-dd16-3443-988e-d3525b2b7715",
    "issues_open": 0,
    "release_version": "2.15.0",
    "release_owners": []
  },

Issues Resolved

Part of #51

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 56.75676% with 16 lines in your changes missing coverage. Please review.

Project coverage is 82.96%. Comparing base (8f33f15) to head (310431b).
Report is 1 commits behind head on main.

Files Patch % Lines
.../opensearchmetrics/metrics/MetricsCalculation.java 25.00% 15 Missing ⚠️
...rchmetrics/metrics/release/ReleaseRepoFetcher.java 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #67      +/-   ##
============================================
+ Coverage     76.70%   82.96%   +6.26%     
- Complexity      190      202      +12     
============================================
  Files            53       53              
  Lines          1189     1186       -3     
  Branches         49       48       -1     
============================================
+ Hits            912      984      +72     
+ Misses          254      180      -74     
+ Partials         23       22       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prudhvigodithi prudhvigodithi force-pushed the central branch 2 times, most recently from 9e30fc7 to 0b0f739 Compare August 27, 2024 00:22
@prudhvigodithi prudhvigodithi marked this pull request as ready for review August 27, 2024 01:17
@prudhvigodithi
Copy link
Member Author

Merging this as this PR improved the code coverage to 82.96%.

@prudhvigodithi prudhvigodithi merged commit 1237830 into opensearch-project:main Aug 27, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants