Fix integrationTest builds for JDK-11 sourcesets #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
requested review from
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
reta
force-pushed
the
fix.integ
branch
8 times, most recently
from
4c54f59 to
bdb5fab
Compare
reta
changed the title
dblock
approved these changes
May 6, 2024
dblock
requested changes
May 6, 2024
There was a problem hiding this comment.
https://github.com/opensearch-project/opensearch-java/actions/runs/8971819529?pr=968 (2.11) fails. The version check bash-style is a bit fragile :)
Ah, the change came out in 2.12.0, fixing it, thanks @dblock ! |
Signed-off-by: Andriy Redko <[email protected]>
VachaShah
approved these changes
May 6, 2024
|
@dblock LGTY? |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 7, 2024
Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit de05226) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
May 7, 2024
Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit de05226) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]>
reta
pushed a commit
that referenced
this pull request
May 7, 2024
Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit de05226) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]>
reta
pushed a commit
that referenced
this pull request
May 7, 2024
Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit de05226) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <[email protected]>
reta
pushed a commit
that referenced
this pull request
May 7, 2024
(cherry picked from commit de05226) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix ntegrationTest builds for JDK-11 sourcesets
Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.