Fix serialization of time_zone field in CompositeDateHistogramAggregationSource #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcrespel
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli,
VachaShah and
Xtansia
as code owners
…tionSource Signed-off-by: Fabien Crespel <[email protected]>
fcrespel
force-pushed
the
fix-time-zone-in-compositedatehistogramaggregationsource
branch
from
d787bc7 to
95a3949
Compare
|
@fcrespel thank you, could you please add some tests as well? thanks! |
Signed-off-by: Fabien Crespel <[email protected]>
|
@reta I added a simple deserialization/serialization test, is that OK? |
reta
approved these changes
Dec 21, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 21, 2024
…tionSource (#1362) * Fix serialization of time_zone field in CompositeDateHistogramAggregationSource Signed-off-by: Fabien Crespel <[email protected]> * Add test for CompositeDateHistogramAggregationSource Signed-off-by: Fabien Crespel <[email protected]> --------- Signed-off-by: Fabien Crespel <[email protected]> (cherry picked from commit 5aef053) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Dec 21, 2024
…tionSource (#1362) (#1363) * Fix serialization of time_zone field in CompositeDateHistogramAggregationSource * Add test for CompositeDateHistogramAggregationSource --------- (cherry picked from commit 5aef053) Signed-off-by: Fabien Crespel <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the serialization of the
time_zonefield inCompositeDateHistogramAggregationSource. Previously, it was incorrectly serialized aszone_id, which does not exist server-side, and documented as required instead of optional. NewtimeZone()accessors are added for consistency with the field name, but oldzoneId()ones are preserved with@Deprecatedannotations for backward compatibility.Issues Resolved
Closes #1142
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.