-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate GetSnapshot #1299
Generate GetSnapshot #1299
Conversation
Signed-off-by: Tatsuya Kawakami <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @hogesako, thank you for picking this up end-to-end! 🙌
This is somewhat tricky from the breaking change perspective, as it's technically breaking, but it is just removing things that were never supported by OpenSearch and were stopping making GetSnapshot requests, so is also really a fix.
If we're wanting to backport this to 2.x, this needs an entry added to the CHANGELOG, otherwise if it's just going in the eventual 3.x it should be documented in UPGRADING.
@reta Do you have any opinions or reservations about backporting this to 2.x?
java-client/src/generated/java/org/opensearch/client/opensearch/snapshot/SnapshotInfo.java
Show resolved
Hide resolved
Signed-off-by: Tatsuya Kawakami <[email protected]>
@Xtansia |
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
@Xtansia |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-java/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/opensearch-java/backport-2.x
# Create a new branch
git switch --create backport/backport-1299-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1c7c6e065b22b4a275a335f13eb06aa17ec20a87
# Push it to GitHub
git push --set-upstream origin backport/backport-1299-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-java/backport-2.x Then, create a pull request where the |
@hogesako It will need to be manually backported but tweaked to minimise breaking changes in 2.x |
* Generate get snapshot Signed-off-by: Tatsuya Kawakami <[email protected]> * add changelog Signed-off-by: Tatsuya Kawakami <[email protected]> * Update codegen Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Tatsuya Kawakami <[email protected]> Signed-off-by: Thomas Farr <[email protected]> Co-authored-by: Thomas Farr <[email protected]> (cherry picked from commit 1c7c6e0)
* Generate get snapshot Signed-off-by: Tatsuya Kawakami <[email protected]> * add changelog Signed-off-by: Tatsuya Kawakami <[email protected]> * Update codegen Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Tatsuya Kawakami <[email protected]> Signed-off-by: Thomas Farr <[email protected]> Co-authored-by: Thomas Farr <[email protected]> (cherry picked from commit 1c7c6e0)
* Generate get snapshot Signed-off-by: Tatsuya Kawakami <[email protected]> * add changelog Signed-off-by: Tatsuya Kawakami <[email protected]> * Update codegen Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Tatsuya Kawakami <[email protected]> Signed-off-by: Thomas Farr <[email protected]> Co-authored-by: Thomas Farr <[email protected]> (cherry picked from commit 1c7c6e0)
* Generate get snapshot Signed-off-by: Tatsuya Kawakami <[email protected]> * add changelog Signed-off-by: Tatsuya Kawakami <[email protected]> * Update codegen Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Tatsuya Kawakami <[email protected]> Signed-off-by: Thomas Farr <[email protected]> Co-authored-by: Thomas Farr <[email protected]> (cherry picked from commit 1c7c6e0)
Description
Generate GetSnapshot
opensearch-project/opensearch-api-specification#606
Issues Resolved
GetSnapshot is just an example and may not be resolved.
#420
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.