Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate KnnVectorProperty #1255

Merged

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Oct 31, 2024

Description

Generate KnnVectorProperty

Issues Resolved

Fixes #1254

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Signed-off-by: Thomas Farr <[email protected]>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dblock dblock merged commit 71d63d0 into opensearch-project:main Nov 1, 2024
56 checks passed
@Xtansia Xtansia deleted the feat/code-gen/knn-vector-property branch November 3, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support data_type property for KnnVectorProperty
2 participants