Fixes #1116 - Add cancel_after_time_interval #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: uri.nudelman <[email protected]>
Signed-off-by: uri.nudelman <[email protected]>
Signed-off-by: uri.nudelman <[email protected]>
urinud
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli,
VachaShah and
Xtansia
as code owners
Signed-off-by: uri.nudelman <[email protected]>
|
Hello @dblock what do you think of this PR ? |
dblock
previously approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Thanks!
- @Xtansia is working to generate this code from spec in https://github.com/opensearch-project/opensearch-api-specification, @urinud can you help making sure this field exists and is used in tests in that project?
- Looks good!
Leaving this open for @Xtansia to make sure this is in line with what the spec will do.
|
@dblock & @Xtansia , I see the field defined in: |
Xtansia
requested changes
Aug 21, 2024
| * <p> | ||
| * API name: {@code cancel_after_time_interval} | ||
| */ | ||
| public final Builder cancelAfterTimeInterval(@Nullable Time value) { |
There was a problem hiding this comment.
This should also have the builder Function overload like you've added to SearchRequest
There was a problem hiding this comment.
@Xtansia , added the function overload method.
I did not added initially becase no other method has function overloads.
Signed-off-by: uri.nudelman <[email protected]>
Xtansia
approved these changes
Aug 21, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
* Fixes #1116 Signed-off-by: uri.nudelman <[email protected]> * Adds MsearchRequest. Fixes SearchRequest. Signed-off-by: uri.nudelman <[email protected]> * Update CHANGELOG.md Signed-off-by: uri.nudelman <[email protected]> * spotlessJavaCheck Signed-off-by: uri.nudelman <[email protected]> * Adds Builder Function method in MSearch Signed-off-by: uri.nudelman <[email protected]> --------- Signed-off-by: uri.nudelman <[email protected]> Co-authored-by: uri.nudelman <[email protected]> (cherry picked from commit c84ad24) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Xtansia
pushed a commit
that referenced
this pull request
Aug 21, 2024
* Fixes #1116 * Adds MsearchRequest. Fixes SearchRequest. * Update CHANGELOG.md * spotlessJavaCheck * Adds Builder Function method in MSearch --------- (cherry picked from commit c84ad24) Signed-off-by: uri.nudelman <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: uri.nudelman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves.
Add
cancel_after_time_intervalfield toSearchRequestandMsearchRequestrequests in the Java client.Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.