Default normalizer deserialization to custom type when unspecified #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blomex
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli,
VachaShah and
Xtansia
as code owners
Signed-off-by: beniamin.jedrychowsk <[email protected]>
Blomex
force-pushed
the
fix/custom-normalizer-deserialization
branch
from
4736038 to
10f2928
Compare
Signed-off-by: beniamin.jedrychowsk <[email protected]>
Xtansia
requested changes
Jul 28, 2024
fixed changelog formatting Co-authored-by: Thomas Farr <[email protected]> Signed-off-by: Beniamin Jędrychowski <[email protected]>
Xtansia
approved these changes
Jul 29, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
…1111) * Default normalizer deserialization to custom type when unspecified Signed-off-by: beniamin.jedrychowsk <[email protected]> * fix style Signed-off-by: beniamin.jedrychowsk <[email protected]> * Update CHANGELOG.md fixed changelog formatting Co-authored-by: Thomas Farr <[email protected]> Signed-off-by: Beniamin Jędrychowski <[email protected]> --------- Signed-off-by: beniamin.jedrychowsk <[email protected]> Signed-off-by: Beniamin Jędrychowski <[email protected]> Co-authored-by: Thomas Farr <[email protected]> (cherry picked from commit 905aa34) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
Thanks @Blomex! |
Xtansia
added a commit
that referenced
this pull request
Jul 29, 2024
…1111) (#1114) * Default normalizer deserialization to custom type when unspecified * fix style * Update CHANGELOG.md fixed changelog formatting --------- (cherry picked from commit 905aa34) Signed-off-by: beniamin.jedrychowsk <[email protected]> Signed-off-by: Beniamin Jędrychowski <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Thomas Farr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an error when deserializing a normalizer without an explicit type specified:
JsonParsingException: Property 'type' not found
at org.opensearch.client.json.JsonpUtils.lookAheadFieldValue(JsonpUtils.java:145)
The server requires type to be specified unless tokenizer is specified then type: custom is assumed, thus any normalizer without type specified is a custom analyzer.
Issues Resolved
Fixes #1110
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.