Fix error deserialization with AwsSdk2Transport (#1068) #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workmanw
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli,
VachaShah and
Xtansia
as code owners
workmanw
force-pushed
the
issue-1068-failed-test
branch
3 times, most recently
from
770c8f6 to
55ec878
Compare
workmanw
force-pushed
the
issue-1068-failed-test
branch
from
55ec878 to
6f2ec50
Compare
workmanw
commented
Jul 17, 2024
| @@ -617,6 +633,22 @@ private static <T> Optional<T> or(Optional<T> opt, Supplier<? extends Optional<? | |||
| } | |||
| } | |||
|
|
|||
| private static ByteArrayInputStream toByteArrayInputStream(InputStream is) throws IOException { | |||
There was a problem hiding this comment.
I'm not crazy about this solution, but it's effectively what ApacheHttpClient5Transport is doing by using BufferedHttpEntity.
Xtansia
previously approved these changes
Jul 17, 2024
java-client/src/main/java/org/opensearch/client/transport/aws/AwsSdk2Transport.java
Outdated
Show resolved
Hide resolved
workmanw
force-pushed
the
issue-1068-failed-test
branch
from
6f2ec50 to
787c0e5
Compare
reta
reviewed
Jul 17, 2024
java-client/src/main/java/org/opensearch/client/transport/aws/AwsSdk2Transport.java
Outdated
Show resolved
Hide resolved
reta
previously approved these changes
Jul 17, 2024
Signed-off-by: Wesley Workman <[email protected]>
workmanw
force-pushed
the
issue-1068-failed-test
branch
from
787c0e5 to
6096a7b
Compare
Xtansia
approved these changes
Jul 17, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
Signed-off-by: Wesley Workman <[email protected]> (cherry picked from commit 5ec233d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Xtansia
pushed a commit
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit 5ec233d) Signed-off-by: Wesley Workman <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
workmanw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a failing test forFix for #1068