Add support for phase_took & search_pipeline request params #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzane17
force-pushed
the
phase-took
branch
2 times, most recently
from
6649a17 to
de41971
Compare
dzane17
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
dblock
previously requested changes
Jun 21, 2024
Signed-off-by: David Zane <[email protected]>
dblock
reviewed
Jul 2, 2024
| public void phaseTook() { | ||
| SearchRequest request = new SearchRequest.Builder().phaseTook(true).build(); | ||
|
|
||
| assertEquals("{}", toJson(request)); |
There was a problem hiding this comment.
Shouldn't phase_took appear somewhere in the JSON?
There was a problem hiding this comment.
phase_took and pipeline are query parameters whereas search_after and ext are in the request body. I think that's what toJson is testing
|
@Xtansia care to take a look? |
Xtansia
approved these changes
Jul 2, 2024
|
Looks correct to me |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1036-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a8aa97ba52090344c8fbbf0f5ebc33835dc1440b
# Push it to GitHub
git push --set-upstream origin backport/backport-1036-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
|
@dzane17 Could you please follow the above instructions to backport this change into the |
dzane17
added a commit
to dzane17/opensearch-java
that referenced
this pull request
Jul 3, 2024
…ch-project#1036) Signed-off-by: David Zane <[email protected]> (cherry picked from commit a8aa97b)
|
@Xtansia Done, created 2.x backport PR. Please review above. Thanks |
Xtansia
pushed a commit
that referenced
this pull request
Jul 3, 2024
…1067) Signed-off-by: David Zane <[email protected]> (cherry picked from commit a8aa97b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for
phase_took&search_pipelinerequest params to OpenSearch Java clientRef in OpenSearch Core: RestSearchAction.java#L150-L227
Issues Resolved
Resolves #1025
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.