-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text embedding processor #1007
Add text embedding processor #1007
Conversation
790c470
to
fa790af
Compare
Signed-off-by: miguel-vila <[email protected]>
Signed-off-by: miguel-vila <[email protected]>
aa753b3
to
90f78e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty straightforward. Please add a test?
* compatible open source license. | ||
*/ | ||
|
||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry was this class copied for Elasticsearch codebase? If not, we could only keep SPDX License
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, probably something I copied and pasted from another processor class, fixed at: 752df7b
Signed-off-by: miguel-vila <[email protected]>
Signed-off-by: miguel-vila <[email protected]>
Signed-off-by: miguel-vila <[email protected]>
@reta LGTM |
* Add text embedding processor Signed-off-by: miguel-vila <[email protected]> * add changelog entry Signed-off-by: miguel-vila <[email protected]> * add (de)serialization test Signed-off-by: miguel-vila <[email protected]> * fix files headers Signed-off-by: miguel-vila <[email protected]> * fix for java 8 Signed-off-by: miguel-vila <[email protected]> --------- Signed-off-by: miguel-vila <[email protected]> (cherry picked from commit 5b90848) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add text embedding processor * add changelog entry * add (de)serialization test * fix files headers * fix for java 8 --------- (cherry picked from commit 5b90848) Signed-off-by: miguel-vila <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Adds the text embedding processor: https://opensearch.org/docs/latest/ingest-pipelines/processors/text-embedding/
Issues Resolved
Should close #1005
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.