Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support text embedding processor #1005

Closed
miguel-vila opened this issue May 30, 2024 · 3 comments · Fixed by #1007
Closed

[FEATURE] Support text embedding processor #1005

miguel-vila opened this issue May 30, 2024 · 3 comments · Fixed by #1007
Labels
enhancement New feature or request

Comments

@miguel-vila
Copy link
Contributor

Not sure if I missed something in the org.opensearch.client.opensearch.ingest.Processor class, but it seems there's no constructor for the text embedding processor as specified here. But, looking at the OpenAPI spec, it seems it's missing from there as well.

Am I missing something? Does the Java client depend on the OpenAPI spec?

@miguel-vila miguel-vila added enhancement New feature or request untriaged labels May 30, 2024
@dblock
Copy link
Member

dblock commented May 30, 2024

Am I missing something? Does the Java client depend on the OpenAPI spec?

Not yet. We have a PR up for that from @Xtansia and fully expect that to get finished and merged shortly. #366 - Take a look?

@dblock
Copy link
Member

dblock commented May 30, 2024

But, looking at the OpenAPI spec, it seems it's missing from there as well.

Can you contribute it to the spec? You can also hand-roll the code in opensearch-java for it now if you want it in faster.

@miguel-vila
Copy link
Contributor Author

here's the spec PR: opensearch-project/opensearch-api-specification#304

@reta reta closed this as completed in #1007 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants