Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ISM issues #609

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Fix ISM issues #609

merged 2 commits into from
Aug 30, 2024

Conversation

Jakob3xD
Copy link
Collaborator

Description

  • Fix ISM Transition to omitempty Conditions field
  • Fix ISM Allocation field types

Issues Resolved

Closes #591

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.99%. Comparing base (06a6dc8) to head (b256229).
Report is 65 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #609       +/-   ##
===========================================
+ Coverage   57.29%   67.99%   +10.70%     
===========================================
  Files         315      376       +61     
  Lines        9823     8862      -961     
===========================================
+ Hits         5628     6026      +398     
+ Misses       2902     1555     -1347     
+ Partials     1293     1281       -12     
Flag Coverage Δ
integration 60.35% <ø> (+9.51%) ⬆️
unit 15.37% <ø> (+2.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
plugins/ism/api_policies.go 100.00% <ø> (ø)

... and 274 files with indirect coverage changes

@dblock dblock merged commit 45c6c6d into opensearch-project:main Aug 30, 2024
57 checks passed
@Jakob3xD Jakob3xD deleted the jh-ism branch September 3, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ISM Allocation action does not match Opensearch server expectation
2 participants