Fix ISM Plugin Transitions Conditions struct (#555) #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Tammaru <[email protected]>
emtammaru
requested review from
dblock,
VijayanB,
VachaShah and
Jakob3xD
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
===========================================
+ Coverage 57.29% 67.96% +10.67%
===========================================
Files 315 376 +61
Lines 9823 8853 -970
===========================================
+ Hits 5628 6017 +389
+ Misses 2902 1555 -1347
+ Partials 1293 1281 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
added 2 commits
May 29, 2024 16:01
Signed-off-by: Erik Tammaru <[email protected]>
Signed-off-by: Erik Tammaru <[email protected]>
|
One more reason for #284, maybe @emtammaru you have some thoughts as a first time contributor. |
|
Maybe you're interested in helping? :) wink wink |
|
Will think about it haha maybe on a rainy day. Has anyone else started on it yet? |
I don't believe so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Resolved
Closes #555
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.