Revert "Draft: Add Err() function to Response for detailed errors (#2… #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-project#322) * Revert "Draft: Add Err() function to Response for detailed errors (opensearch-project#246)" This reverts commit 8d3cf4d. Signed-off-by: Vacha Shah <[email protected]> * Fixing PIT APIs introduced in PR opensearch-project#253 since they use response.Err() Signed-off-by: Vacha Shah <[email protected]> * Removing opensearchapi.Error usage from snapshot tests introduced in PR opensearch-project#237 Signed-off-by: Vacha Shah <[email protected]> * Resolve Changelog conflicts Signed-off-by: Vacha Shah <[email protected]> --------- Signed-off-by: Vacha Shah <[email protected]>
dblock
approved these changes
Oct 3, 2023
|
But this PR is into main, so it's reverting a change that should stay in 3.0, no? |
|
Oh my bad 🤦🏼♀️ . I will raise against 2.x. Thank you for pointing out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…… (#322)
This reverts commit 8d3cf4d.
Fixing PIT APIs introduced in PR Add point in time api #253 since they use response.Err()
Removing opensearchapi.Error usage from snapshot tests introduced in PR SnapshotDeleteRequest use []string instead of string #237
Resolve Changelog conflicts
Description
I created a 2.x branch from main to track the 2.x line and this PR is to revert the breaking change on 2.x. Similar process was done when releasing version 2.3, 2.x has all latest changes from main and the breaking change is being reverted here.
Doing this so we can move to releasing a 3.0 version.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.