[Workspace] add tests for data source association and dissociation #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tygao <[email protected]>
raintygao
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
zhongnansu and
yujin-emma
as code owners
Hailong-am
approved these changes
Nov 15, 2024
SuZhou-Joe
reviewed
Nov 18, 2024
| let dataSourceId2; | ||
| if ( | ||
| Cypress.env('WORKSPACE_ENABLED') && | ||
| Cypress.env('SECURITY_ENABLED') && |
There was a problem hiding this comment.
Do we need security enabled for testing data source association?
There was a problem hiding this comment.
Do you mean we don't need this verification?
SuZhou-Joe
reviewed
Nov 18, 2024
| cy.deleteWorkspaceById(workspaceId); | ||
| }); | ||
|
|
||
| it('should associate and dissociate data source successfully', () => { |
There was a problem hiding this comment.
Do we need to add test cases for associating DQC?
There was a problem hiding this comment.
We don't have related infra of this type data source for now, may need to figure out a way to create this type data source with related team first.
Signed-off-by: tygao <[email protected]>
SuZhou-Joe
approved these changes
Nov 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
…1646) * add tests for data source association and dissociation Signed-off-by: tygao <[email protected]> * remove security verification Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> (cherry picked from commit 7003895)
SuZhou-Joe
pushed a commit
that referenced
this pull request
Nov 19, 2024
…1646) (#1655) * add tests for data source association and dissociation Signed-off-by: tygao <[email protected]> * remove security verification Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> (cherry picked from commit 7003895) Co-authored-by: Tianyu Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add tests for data source association and dissociation
Screenshot
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.