Add cypress test for workspace overview page #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
changed the title
Hailong-am
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu and
yujin-emma
as code owners
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
wanglam
reviewed
Nov 12, 2024
...-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_analytics_overviews.spec.js
Outdated
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Nov 12, 2024
Comment on lines
+20
to
+35
| const createWorkspace = (datasourceId) => { | ||
| cy.createWorkspace({ | ||
| name: workspaceName, | ||
| description: workspaceDescription, | ||
| features: workspaceFeatures, | ||
| settings: { | ||
| permissions: { | ||
| library_write: { users: ['%me%'] }, | ||
| write: { users: ['%me%'] }, | ||
| }, | ||
| ...(datasourceId ? { dataSources: [datasourceId] } : {}), | ||
| }, | ||
| }).then((value) => { | ||
| workspaceId = value; | ||
| }); | ||
| }; |
There was a problem hiding this comment.
Suggested change
| const createWorkspace = (datasourceId) => { | |
| cy.createWorkspace({ | |
| name: workspaceName, | |
| description: workspaceDescription, | |
| features: workspaceFeatures, | |
| settings: { | |
| permissions: { | |
| library_write: { users: ['%me%'] }, | |
| write: { users: ['%me%'] }, | |
| }, | |
| ...(datasourceId ? { dataSources: [datasourceId] } : {}), | |
| }, | |
| }).then((value) => { | |
| workspaceId = value; | |
| }); | |
| }; | |
| const createWorkspace = (datasourceId) => { | |
| cy.createWorkspace({ | |
| name: workspaceName, | |
| description: workspaceDescription, | |
| features: workspaceFeatures, | |
| settings: { | |
| permissions: { | |
| library_write: { users: ['%me%'] }, | |
| write: { users: ['%me%'] }, | |
| }, | |
| ...(datasourceId ? { dataSources: [datasourceId] } : {}), | |
| }, | |
| }).then((value) => { | |
| workspaceId = value; | |
| }); | |
| }; |
We can move the function to a util function maybe?
There was a problem hiding this comment.
cy.createWorkspace already been a util function, and this createWorkspace function just utilized the cy.createWorkspace to create workspace with and without datasource. To move it to a common place as util function may not benefits other test cases.
Signed-off-by: Hailong Cui <[email protected]>
|
@Hailong-am The |
SuZhou-Joe
approved these changes
Nov 13, 2024
Signed-off-by: Hailong Cui <[email protected]>
wanglam
approved these changes
Nov 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
* cypress test for use case overview page Signed-off-by: Hailong Cui <[email protected]> * add cypress test for analytics overview page Signed-off-by: Hailong Cui <[email protected]> * add sample data cleanup Signed-off-by: Hailong Cui <[email protected]> * support mds is not enabled Signed-off-by: Hailong Cui <[email protected]> * remove alerts cards Signed-off-by: Hailong Cui <[email protected]> * fix failed test case Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 295636c)
Hailong-am
added a commit
that referenced
this pull request
Nov 15, 2024
* cypress test for use case overview page Signed-off-by: Hailong Cui <[email protected]> * add cypress test for analytics overview page Signed-off-by: Hailong Cui <[email protected]> * add sample data cleanup Signed-off-by: Hailong Cui <[email protected]> * support mds is not enabled Signed-off-by: Hailong Cui <[email protected]> * remove alerts cards Signed-off-by: Hailong Cui <[email protected]> * fix failed test case Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 295636c) Co-authored-by: Hailong Cui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add cypress test for essential/search/analytics overview page
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.