Add bwc.checkout.align parameter support in gradle-check #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabh6788
requested review from
peterzhuamazon,
prudhvigodithi,
gaiksaya,
Divyaasm and
zelinh
as code owners
Signed-off-by: Rishabh Singh <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
============================================
+ Coverage 84.23% 84.26% +0.03%
Complexity 80 80
============================================
Files 105 106 +1
Lines 520 521 +1
Branches 61 61
============================================
+ Hits 438 439 +1
Misses 26 26
Partials 56 56 ☔ View full report in Codecov by Sentry. |
andrross
approved these changes
Jun 28, 2024
gaiksaya
reviewed
Jun 28, 2024
| @@ -71,7 +78,7 @@ void call(Map args = [:]) { | |||
|
|
|||
| echo "Start gradlecheck" | |||
| GRADLE_CHECK_STATUS=0 | |||
| ./gradlew clean && ./gradlew check -Dtests.coverage=true --no-daemon --no-scan || GRADLE_CHECK_STATUS=1 | |||
| ./gradlew clean && ./gradlew check -Dtests.coverage=true ${bwc_checkout_align_param} --no-daemon --no-scan || GRADLE_CHECK_STATUS=1 | |||
There was a problem hiding this comment.
Does the below suggestion make it less confusing?
Suggested change
| ./gradlew clean && ./gradlew check -Dtests.coverage=true ${bwc_checkout_align_param} --no-daemon --no-scan || GRADLE_CHECK_STATUS=1 | |
| ./gradlew clean && ./gradlew check -Dtests.coverage=true -Dbwc.checkout.align=${bwc_checkout_align} --no-daemon --no-scan || GRADLE_CHECK_STATUS=1 |
There was a problem hiding this comment.
Why add it when it is set to false by default.
Honestly doesn't make any difference.
There was a problem hiding this comment.
Just in case the default value changes in OpenSearch repo, it will be easier to debug using the command in the gradle check run. Your call
There was a problem hiding this comment.
I feel like at the moment we can keep it removed if false, since it is the origin behavior unchanged.
gaiksaya
approved these changes
Jun 28, 2024
peterzhuamazon
approved these changes
Jul 1, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 1, 2024
Signed-off-by: Rishabh Singh <[email protected]> (cherry picked from commit 9338046) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rishabh6788
pushed a commit
that referenced
this pull request
Jul 1, 2024
Signed-off-by: Rishabh Singh <[email protected]> (cherry picked from commit 9338046) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
bwc.checkout.alignparameter support in gradle-check.Issues Resolved
#420
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.