Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the move command in retrievePreviousBuild to fix bug in windows #378

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Feb 1, 2024

Description

Update the move command in retrievePreviousBuild to fix bug in windows

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d560891) 86.11% compared to head (8adb6f5) 86.11%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #378   +/-   ##
=========================================
  Coverage     86.11%   86.11%           
  Complexity       29       29           
=========================================
  Files            82       82           
  Lines           216      216           
  Branches         12       12           
=========================================
  Hits            186      186           
  Misses           22       22           
  Partials          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

build.gradle Outdated
@@ -121,7 +121,7 @@ jacocoTestReport {
}
}

String version = '6.2.0'
String version = '6.2.1'
Copy link
Member

@gaiksaya gaiksaya Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you not bump the version? I can take care of it in my upcoming PR. Thanks! Need to bump minor version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When are you planning to bump this version? This is fixing the distribution build so we might want to bump it soon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By EOD. We are having too many tags for 1 fixes. Trying to club 3 changes together.

Copy link
Member Author

@zelinh zelinh Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it back. Please prioritize the version bump so that we could update our build Jenkinsfiles with new tag version. Thanks.

@peterzhuamazon peterzhuamazon merged commit d7dd07c into opensearch-project:main Feb 1, 2024
10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 1, 2024
#378)

Signed-off-by: Zelin Hao <[email protected]>
(cherry picked from commit d7dd07c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@zelinh zelinh deleted the update-mv branch February 1, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants