-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add windows CI #327
Merged
Merged
Add windows CI #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rupa Lahiri <[email protected]>
rblcoder
requested review from
peterzhuamazon,
prudhvigodithi,
gaiksaya and
rishabh6788
as code owners
October 17, 2023 10:27
Codecov Report
@@ Coverage Diff @@
## main #327 +/- ##
=========================================
Coverage 87.43% 87.43%
Complexity 29 29
=========================================
Files 81 81
Lines 207 207
Branches 11 11
=========================================
Hits 181 181
Misses 19 19
Partials 7 7 |
gaiksaya
requested changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also try to raise a PR against your fork and branch to see if the CI is getting through on windows?
Signed-off-by: Rupa Lahiri <[email protected]>
…-libraries into add-windows-ci
Signed-off-by: Rupa Lahiri <[email protected]>
Signed-off-by: Rupa Lahiri <[email protected]>
gaiksaya
approved these changes
Oct 18, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
Signed-off-by: Rupa Lahiri <[email protected]> (cherry picked from commit babf108) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add windows CI
Issues Resolved
closes #8
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.