Sorting Hybrid Search #363
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Jain <[email protected]>
| @@ -9,7 +9,7 @@ | |||
| ] | |||
| }, | |||
| { | |||
| "name": "hybrid-query-aggs-full", | |||
| "name": "bool-vs-hybrid", | |||
There was a problem hiding this comment.
why this name changed? We're not comparing two query types, initial meaning is - run full search load for hybrid query.
There was a problem hiding this comment.
Apart from the name's semantic such change isn't backward compatible, this workload has been released and may be in use. If you're in strong need of procedure with new name better to create new one.
| @@ -52,6 +52,47 @@ | |||
| } | |||
| } | |||
| }, | |||
| { | |||
| "name": "bool-only-term-range-date-sort", | |||
There was a problem hiding this comment.
why we need this operation as part of the workload? same is for all others with bool query.
If you want to have some baseline you can add bool with sorting for only medium subset. That should be enough to see if some deviation is there. Others will just increase running time without adding a value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.