Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter workflow #240

Merged
merged 11 commits into from
Apr 15, 2024
Merged

Linter workflow #240

merged 11 commits into from
Apr 15, 2024

Conversation

nhtruong
Copy link
Collaborator

@nhtruong nhtruong commented Apr 12, 2024

Description

  • Add new validations:
    • Description must ends with a period
    • Enforcing parameter naming convention
  • Fixed linter errors
  • Added lint github workflow

Issues Resolved

closes #205

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

API specs implemented for 246/649 (37%) APIs.

Signed-off-by: Theo Truong <[email protected]>
Copy link
Contributor

API specs implemented for 246/649 (37%) APIs.

Copy link
Contributor

API specs implemented for 246/649 (37%) APIs.

Copy link
Contributor

API specs implemented for 246/649 (37%) APIs.

@nhtruong nhtruong marked this pull request as ready for review April 12, 2024 20:33
dblock
dblock previously approved these changes Apr 13, 2024
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, merge after.

@@ -0,0 +1,27 @@
name: Validate Spec Folder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validate Spec

(we aren't validating a folder)

tools/linter/components/NamespaceFile.ts Outdated Show resolved Hide resolved
tools/linter/components/Operation.ts Show resolved Hide resolved
Copy link
Contributor

API specs implemented for 246/649 (37%) APIs.

@dblock dblock merged commit 198473d into opensearch-project:main Apr 15, 2024
5 checks passed
@nhtruong nhtruong deleted the linter_workflow- branch April 15, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Lint API specs
2 participants