Set notifications plugin 3.0.0 baseline JDK version to JDK-21 #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andriy Redko <[email protected]>
reta
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
zhongnansu,
sbcd90,
praveensameneni and
amsiglan
as code owners
reta
commented
Oct 8, 2024
| @@ -6,7 +6,7 @@ | |||
| import com.github.jengelman.gradle.plugins.shadow.ShadowBasePlugin | |||
|
|
|||
| plugins { | |||
| id 'com.github.johnrengelman.shadow' | |||
| id 'io.github.goooler.shadow' version "8.1.7" | |||
There was a problem hiding this comment.
reta
commented
Oct 8, 2024
| @@ -41,6 +42,16 @@ buildscript { | |||
| classpath "io.gitlab.arturbosch.detekt:detekt-gradle-plugin:1.23.0" | |||
| classpath "org.jacoco:org.jacoco.agent:0.8.11" | |||
| } | |||
|
|
|||
| configurations { | |||
There was a problem hiding this comment.
yuye-aws
reviewed
Oct 9, 2024
Signed-off-by: Andriy Redko <[email protected]>
yuye-aws
approved these changes
Oct 9, 2024
|
Approved the CI to run. Can maintainers of this repo help move this PR forward? |
Hailong-am
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set notifications plugin 3.0.0 baseline JDK version to JDK-21
Related Issues
Closes #924
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.