doing HTTP response string truncation manually to support backports #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Toepker <[email protected]>
toepkerd
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
zhongnansu,
sbcd90,
praveensameneni and
amsiglan
as code owners
Hailong-am
reviewed
Feb 28, 2024
| var responseString = EntityUtils.toString(entity) | ||
| if (responseString.length > (PluginSettings.maxHttpResponseSize / 2)) { // Java char is 2 bytes | ||
| responseString = responseString.substring(0, PluginSettings.maxHttpResponseSize / 2) | ||
| } |
There was a problem hiding this comment.
if we read the response fully, could that prevent the DDos? e.g. if the response have 1T, we still read them all into memory. Could be better to mimic the logic in EntityUtils in http5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of leaving HTTP response string truncation to
apache.hc.core5's toString(), which comes with a max string length argument, we do the truncation manually to support backports since previous versions don't useapache.hc.core5.Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.