-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding hostname support for notifications deny list #858
Conversation
Signed-off-by: Dennis Toepker <[email protected]>
In regards to the failing CIs, when built locally, the repo with my changes stashed away failed on the same BWC task for the same reasons:
|
notifications/core/src/main/kotlin/org/opensearch/notifications/core/utils/ValidationHelpers.kt
Show resolved
Hide resolved
...tions/core/src/test/kotlin/org/opensearch/notifications/core/utils/ValidationHelpersTests.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Dennis Toepker <[email protected]>
} | ||
} | ||
|
||
@Test | ||
fun `test url in denylist`() { | ||
val urls = listOf("https://www.amazon.com", "https://mytest.com", "https://mytest.com") | ||
fun `test hosts not in denylist`() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a test case which demonstrates the additional checks hostname.equals is doing other than normal string.equals?
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-858-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 39bd3bf824573ad730345f0f2cc9a3cda5be32a4
# Push it to GitHub
git push --set-upstream origin backport/backport-858-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/notifications/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/notifications/backport-2.12 2.12
# Navigate to the new working tree
pushd ../.worktrees/notifications/backport-2.12
# Create a new branch
git switch --create backport/backport-858-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 39bd3bf824573ad730345f0f2cc9a3cda5be32a4
# Push it to GitHub
git push --set-upstream origin backport/backport-858-to-2.12
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/notifications/backport-2.12 Then, create a pull request where the |
…ct#858) Signed-off-by: Dennis Toepker <[email protected]> (cherry picked from commit 39bd3bf)
…ct#858) Signed-off-by: Dennis Toepker <[email protected]> (cherry picked from commit 39bd3bf)
Signed-off-by: Dennis Toepker <[email protected]> (cherry picked from commit 39bd3bf)
Signed-off-by: Dennis Toepker <[email protected]> (cherry picked from commit 39bd3bf)
…ct#858) Signed-off-by: Dennis Toepker <[email protected]> (cherry picked from commit 39bd3bf)
…ct#858) Signed-off-by: Dennis Toepker <[email protected]>
Description
Adds support for checking hostnames in a customer's deny list, in addition to the existing functionality of checking IP addresses.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.