Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed default admin credentials. #837

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

AWSHurneyt
Copy link
Contributor

Description

  1. Adjusted the password used by the security enabled tests based on this comment https://github.com/opensearch-project/anomaly-detection/pull/1134/files#r1462673941
  2. Adjusted the developer guide based on this comment https://github.com/opensearch-project/anomaly-detection/pull/1134/files#r1462674251

Issues Resolved

#832

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AWSHurneyt
Copy link
Contributor Author

AWSHurneyt commented Jan 23, 2024

Need to backport to 2.x and 2.12. I do not have permissions to add labels.

@derek-ho could you help review this PR to ensure these changes meet the requirements of the change to the security plugin?

@zhongnansu could you help apply the backport labels, and review this change?

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e61b8c0) 66.93% compared to head (941fde0) 66.93%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #837   +/-   ##
=========================================
  Coverage     66.93%   66.93%           
  Complexity      267      267           
=========================================
  Files            39       39           
  Lines          1742     1742           
  Branches        165      165           
=========================================
  Hits           1166     1166           
  Misses          453      453           
  Partials        123      123           
Flag Coverage Δ
opensearch-notifications 66.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhichao-aws zhichao-aws merged commit 7f38be1 into opensearch-project:main Jan 24, 2024
20 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-837-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7f38be12b007a8018d25a956a062cb7354a4ff46
# Push it to GitHub
git push --set-upstream origin backport/backport-837-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/notifications/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-837-to-2.x.

@Hailong-am
Copy link
Collaborator

@AWSHurneyt backport 2.x failed, please help to do manual backport for 2.x, thanks.

AWSHurneyt added a commit to AWSHurneyt/notifications that referenced this pull request Jan 24, 2024
Signed-off-by: AWSHurneyt <[email protected]>

(cherry picked from commit 7f38be1)
Signed-off-by: AWSHurneyt <[email protected]>
amsiglan pushed a commit that referenced this pull request Jan 31, 2024
(cherry picked from commit 7f38be1)

Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants