-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed default admin credentials. #837
Conversation
Signed-off-by: AWSHurneyt <[email protected]>
Need to backport to @derek-ho could you help review this PR to ensure these changes meet the requirements of the change to the security plugin? @zhongnansu could you help apply the backport labels, and review this change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
=========================================
Coverage 66.93% 66.93%
Complexity 267 267
=========================================
Files 39 39
Lines 1742 1742
Branches 165 165
=========================================
Hits 1166 1166
Misses 453 453
Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-837-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7f38be12b007a8018d25a956a062cb7354a4ff46
# Push it to GitHub
git push --set-upstream origin backport/backport-837-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/notifications/backport-2.x Then, create a pull request where the |
@AWSHurneyt backport 2.x failed, please help to do manual backport for 2.x, thanks. |
Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 7f38be1) Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 7f38be1) Signed-off-by: AWSHurneyt <[email protected]>
Description
Issues Resolved
#832
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.