Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ktlint change #830

Conversation

zhichao-aws
Copy link
Member

@zhichao-aws zhichao-aws commented Dec 18, 2023

Description

Do ktlint change after upgrade the version of ktlint in #827

Issues Resolved

#826

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: zhichao-aws <[email protected]>
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (whitesource-remediate/com.pinterest-ktlint-0.x@309dcc3). Click here to learn what that means.

Additional details and impacted files
@@                                Coverage Diff                                @@
##             whitesource-remediate/com.pinterest-ktlint-0.x     #830   +/-   ##
=================================================================================
  Coverage                                                  ?   66.93%           
  Complexity                                                ?      267           
=================================================================================
  Files                                                     ?       39           
  Lines                                                     ?     1742           
  Branches                                                  ?      165           
=================================================================================
  Hits                                                      ?     1166           
  Misses                                                    ?      453           
  Partials                                                  ?      123           
Flag Coverage Δ
opensearch-notifications 66.93% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhichao-aws zhichao-aws merged commit dd5a2dc into opensearch-project:whitesource-remediate/com.pinterest-ktlint-0.x Dec 18, 2023
15 of 18 checks passed
Copy link
Member

@yuye-aws yuye-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants