Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disable cookie for webhook #823

Closed
wants to merge 0 commits into from

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Dec 7, 2023

Description

Support disable cookie for webhook by add a new cluster level setting

PUT _cluster/settings
{
  "transient": {
    "opensearch.notifications.core.webhook.disable_http_cookie": true
  }
}

Issues Resolved

#822

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74de907) 66.93% compared to head (9882d74) 66.93%.
Report is 1 commits behind head on main.

❗ Current head 9882d74 differs from pull request most recent head 69d4b3d. Consider uploading reports for the commit 69d4b3d to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #823   +/-   ##
=========================================
  Coverage     66.93%   66.93%           
  Complexity      267      267           
=========================================
  Files            39       39           
  Lines          1742     1742           
  Branches        165      165           
=========================================
  Hits           1166     1166           
  Misses          453      453           
  Partials        123      123           
Flag Coverage Δ
opensearch-notifications 66.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am Hailong-am marked this pull request as ready for review February 19, 2024 02:21
@Hailong-am Hailong-am changed the title [WIP]Support disable cookie for webhook Support disable cookie for webhook Feb 21, 2024
@Hailong-am Hailong-am closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant