Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Re-enable detekt (#796) #808

Merged

Conversation

Noir01
Copy link
Contributor

@Noir01 Noir01 commented Oct 25, 2023

Cherry picked from commit 0e55d38

Description

Bumped version of io.gitlab.arturbosch.detekt:detekt-gradle-plugin to 1.23.0

Issues Resolved

None

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0`

Signed-off-by: Aniruddh <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
(cherry picked from commit 0e55d38)
@Noir01 Noir01 changed the title Re-enable detekt (#796) Backport #796 to 2.x Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #808 (53d44c2) into 2.x (79ffbb5) will not change coverage.
Report is 2 commits behind head on 2.x.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.x     #808   +/-   ##
=========================================
  Coverage     66.45%   66.45%           
  Complexity      263      263           
=========================================
  Files            39       39           
  Lines          1717     1717           
  Branches        165      165           
=========================================
  Hits           1141     1141           
  Misses          453      453           
  Partials        123      123           
Flag Coverage Δ
opensearch-notifications 66.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Hailong-am Hailong-am changed the title Backport #796 to 2.x [Backport] Re-enable detekt (#796) Oct 27, 2023
@Hailong-am Hailong-am changed the title [Backport] Re-enable detekt (#796) [Backport 2.x] Re-enable detekt (#796) Oct 27, 2023
@Noir01
Copy link
Contributor Author

Noir01 commented Oct 29, 2023

@xluo-aws Can you review the PR?

@xluo-aws xluo-aws merged commit ce26eb8 into opensearch-project:2.x Oct 30, 2023
11 of 13 checks passed
@Noir01 Noir01 deleted the backport/backport-796-to-2.x branch October 30, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants