Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added org.apache.logging.log4j:log4j-slf4j-impl to classpath #791

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

Noir01
Copy link
Contributor

@Noir01 Noir01 commented Oct 14, 2023

Description

Fixes warning message shown when sending test message.

Issues Resolved

fix #693

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded.
Followed instructions from warning messages that appear.

Signed-off-by: Noir <[email protected]>
@@ -99,6 +99,7 @@ dependencies {
exclude group: 'org.jetbrains', module: 'annotations' // resolve jarhell
} // ${kotlin_version} does not work for coroutines
implementation "${group}:common-utils:${common_utils_version}"
implementation "org.slf4j:slf4j-jdk14:1.7.32"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add dependency on slf4j-api instead? and use versions.slf4j instead of hard code to 1.7.32?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, instead of having implementation "org.slf4j:slf4j-jdk14:1.7.32", would it be better to have implementation "org.slf4j:slf4j-api:${versions.slf4j}"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please test if the warning is gone or not following the reproduce steps at #693

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By my test, this change doesn't work, the warning log still exists, please dive deep on it, thanks!

@gaobinlong
Copy link
Collaborator

Here are the steps about how to configure the email channel, please show the test result after the code change.

I think the main steps for test can be as follows:

  1. Make some code change.
  2. Build new packages for notification plugin and notification-core plugin: run ./gradlew assemble under the sub-directory notifications in the main directory of this repo.
  3. Build a new package for opensearch core: run ./gradlew localDistro in the main directory of the opensearch repo, see https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md
  4. Step into the directory of the new built package of opensearch core, maybe build/distribution/local/opensearch-3.0.0-SNAPSHOT, install the new built packages of notification-core and notification plugin: ./bin/opensearch-plugin install file:///.../*.zip
  5. Run OpenSearch
  6. Run OpenSearch-Dashboards, need to install the notification dashboard plugin
  7. Config the email sender in OpenSearch-Dashboards, refer to https://opensearch.org/docs/latest/observing-your-data/notifications/index/, here is my test sender:
Pasted Graphic 8. Config keystore, set the email temporary password which is generated by Google APP password(if you use gmail): Stop OpenSearch, run `./bin/opensearch-keystore add opensearch.notifications.core.email.binlong.username`, set it to the email address, and run `./bin/opensearch-keystore add opensearch.notifications.core.email.binlong.password`, set it to the new generated password, note that `binlong` is the name of the email sender created in step 7.
  1. Run OpenSearch

  2. Create a channel in OpenSearch-Dashboards, choose the email sender, click Send test message ,check the main log of OpenSearch.

@Noir01 Noir01 marked this pull request as draft October 25, 2023 16:46
Removed slf4j-jdk14.jar from classpath

Signed-off-by: Aniruddh <[email protected]>
@Noir01
Copy link
Contributor Author

Noir01 commented Oct 28, 2023

I accidentally swapped the commit messages for the two commits I did.

@Noir01 Noir01 marked this pull request as ready for review October 28, 2023 20:02
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #791 (2773cd5) into main (76ddcd4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #791   +/-   ##
=========================================
  Coverage     66.85%   66.85%           
  Complexity      263      263           
=========================================
  Files            39       39           
  Lines          1738     1738           
  Branches        165      165           
=========================================
  Hits           1162     1162           
  Misses          453      453           
  Partials        123      123           
Flag Coverage Δ
opensearch-notifications 66.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Hailong-am Hailong-am changed the title Added slf4j-jdk14.jar to classpath Added org.apache.logging.log4j:log4j-slf4j-impl to classpath Oct 30, 2023
@gaobinlong gaobinlong merged commit 62b7b4f into opensearch-project:main Nov 2, 2023
13 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-791-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 62b7b4f840e7e224f947f1745da375df6f419b9b
# Push it to GitHub
git push --set-upstream origin backport/backport-791-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/notifications/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-791-to-2.x.

@gaobinlong
Copy link
Collaborator

@Noir01 ,automatic backport to 2.x failed, could you please create a backport PR manually?

Noir01 added a commit to Noir01/notifications that referenced this pull request Nov 2, 2023
…rch-project#791)

* Added slf4j-jdk14.jar to classpath

Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded.
Followed instructions from warning messages that appear.

Signed-off-by: Noir <[email protected]>

* Undid 80fc198

Removed slf4j-jdk14.jar from classpath

Signed-off-by: Aniruddh <[email protected]>

* Added org.apache.logging.log4j:log4j-slf4j-impl to classpath

Signed-off-by: Aniruddh <[email protected]>

---------

Signed-off-by: Noir <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
(cherry picked from commit 62b7b4f)
@Noir01 Noir01 deleted the patch-1 branch November 2, 2023 16:14
Noir01 added a commit to Noir01/notifications that referenced this pull request Nov 13, 2023
…rch-project#791)

* Added slf4j-jdk14.jar to classpath

Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded.
Followed instructions from warning messages that appear.

Signed-off-by: Noir <[email protected]>

* Undid 80fc198

Removed slf4j-jdk14.jar from classpath

Signed-off-by: Aniruddh <[email protected]>

* Added org.apache.logging.log4j:log4j-slf4j-impl to classpath

Signed-off-by: Aniruddh <[email protected]>

---------

Signed-off-by: Noir <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Noir01 added a commit to Noir01/notifications that referenced this pull request Nov 16, 2023
…rch-project#791)

* Added slf4j-jdk14.jar to classpath

Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded.
Followed instructions from warning messages that appear.

Signed-off-by: Noir <[email protected]>

* Undid 80fc198

Removed slf4j-jdk14.jar from classpath

Signed-off-by: Aniruddh <[email protected]>

* Added org.apache.logging.log4j:log4j-slf4j-impl to classpath

Signed-off-by: Aniruddh <[email protected]>

---------

Signed-off-by: Noir <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
zhichao-aws added a commit that referenced this pull request Nov 20, 2023
* Microsoft teams (#676)

* Added feature support for microsoft teams webhoo

Signed-off-by: danielkyalo599 <[email protected]>

* Added feature support for microsoft teams webhook ,removed valid webhooks

Signed-off-by: danielkyalo599 <[email protected]>

* Added feature support for Microsoft teams webhook

Signed-off-by: danielkyalo599 <[email protected]>

* Refactored feature support for  ms teams and added unit and integTest

Signed-off-by: danielkyalo599 <[email protected]>

* fix build in core

Signed-off-by: zhichao-aws <[email protected]>

* fix core-spi build

Signed-off-by: zhichao-aws <[email protected]>

* fix notifications main code

Signed-off-by: zhichao-aws <[email protected]>

* fix mappings, add IT

Signed-off-by: zhichao-aws <[email protected]>

* add auto upgrade mapping logic

Signed-off-by: zhichao-aws <[email protected]>

* put load mapping to initialize step

Signed-off-by: zhichao-aws <[email protected]>

* add schema_version field

Signed-off-by: zhichao-aws <[email protected]>

* add integ test

Signed-off-by: zhichao-aws <[email protected]>

* adjust with auto upgrade mapping logic

Signed-off-by: zhichao-aws <[email protected]>

* add bwc

Signed-off-by: zhichao-aws <[email protected]>

* modify bwc

Signed-off-by: zhichao-aws <[email protected]>

* modify bwc

Signed-off-by: zhichao-aws <[email protected]>

* resolve  comments

Signed-off-by: zhichao-aws <[email protected]>

* add license header

Signed-off-by: zhichao-aws <[email protected]>

* fix microsoft teams sample url in IT to adapt url validation

Signed-off-by: zhichao-aws <[email protected]>

---------

Signed-off-by: danielkyalo599 <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Co-authored-by: danielkyalo599 <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Add microsoft teams validation error message (#746)

* add validation failure message for Microsoft Teams

Signed-off-by: zhichao-aws <[email protected]>

* modify integtest

Signed-off-by: zhichao-aws <[email protected]>

---------

Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* onboard system and hidden index (#742)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Updates demo certs used in integ tests (#756)

Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Add 2.10.0 release notes (#755)

* Add 2.10.0 release notes

Signed-off-by: Hailong Cui <[email protected]>

* update release notes

Signed-off-by: Hailong Cui <[email protected]>

* Update opensearch-notifications.release-notes-2.10.0.0.md

Signed-off-by: Hailong Cui <[email protected]>

* fix wrong PR number

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* bump bwc version to 2.11 (#763)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Add 2.11 release notes (#774)

Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Fix integration test failure by allowing direct access to system index warning (#784)

* Fix integration test failure by allowing direct access to system index warning

Signed-off-by: gaobinlong <[email protected]>

* Fix bwc test failure of throwing direct access to system index when getting mapping

Signed-off-by: gaobinlong <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Re-enable detekt

Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0`

Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* bump bwc version to 2.12 (#793)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Update dependency org.json:json to v20231013 (#795)

Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Impove security plugin enabling check (#792)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Add github workflow to auto bump bwc version  (#799)

* Adding bump bwc version github workflow

Signed-off-by: Hailong Cui <[email protected]>

* revert app id

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Replace the TestMailServer to GreenMail server (#801)

* Add 2.11 release notes (#774)

Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: rdani <[email protected]>

* Fix integration test failure by allowing direct access to system index warning (#784)

* Fix integration test failure by allowing direct access to system index warning

Signed-off-by: gaobinlong <[email protected]>

* Fix bwc test failure of throwing direct access to system index when getting mapping

Signed-off-by: gaobinlong <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: rdani <[email protected]>

* Replace the TestMailServer to GreenMail server

Signed-off-by: rdani <[email protected]>

* bump bwc version to 2.12 (#793)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: rdani <[email protected]>

* Update dependency org.json:json to v20231013 (#795)

Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: rdani <[email protected]>

* Re-enable detekt (#796)

Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0`

Signed-off-by: Aniruddh <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
Signed-off-by: rdani <[email protected]>

* Add assertion for retrieval of notification

Signed-off-by: rdani <[email protected]>

* Update to stable version

Signed-off-by: rdani <[email protected]>

* Update to stable version

Signed-off-by: rdani <[email protected]>

* Update to suggested version

Signed-off-by: rdani <[email protected]>

---------

Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: rdani <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
Co-authored-by: Yuye Zhu <[email protected]>
Co-authored-by: gaobinlong <[email protected]>
Co-authored-by: rdani <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
Co-authored-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Onboard prod jenkins docker image to github actions (#809)

* Onboard prod jenkins docker image to github actions

Signed-off-by: Peter Zhu <[email protected]>

* Add more

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Added org.apache.logging.log4j:log4j-slf4j-impl to classpath (#791)

* Added slf4j-jdk14.jar to classpath

Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded.
Followed instructions from warning messages that appear.

Signed-off-by: Noir <[email protected]>

* Undid 80fc198

Removed slf4j-jdk14.jar from classpath

Signed-off-by: Aniruddh <[email protected]>

* Added org.apache.logging.log4j:log4j-slf4j-impl to classpath

Signed-off-by: Aniruddh <[email protected]>

---------

Signed-off-by: Noir <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Added Slack webhook URL validation regex

Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL

Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Replaced more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL

Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Replaced even more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL

Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Replace path of mock Slack URL with `sample_slack_url`

Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Remove slackId from domainIds

Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Replace wrongly formatted dummy Slack URL with properly formatted dummy Slack URL

Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Add tests for wrong Slack URLs

Signed-off-by: Aniruddh <[email protected]>

* Add validation tests for Slack URL

Signed-off-by: Aniruddh <[email protected]>

* Format

Signed-off-by: Aniruddh <[email protected]>

* GovSlack apps can use the slack-gov.com domain

Signed-off-by: Aniruddh <[email protected]>

* Add validation for gov-slack.com domain

Signed-off-by: Aniruddh <[email protected]>

---------

Signed-off-by: danielkyalo599 <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: rdani <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Noir <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
Co-authored-by: zhichao-aws <[email protected]>
Co-authored-by: danielkyalo599 <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
Co-authored-by: Darshit Chanpura <[email protected]>
Co-authored-by: Yuye Zhu <[email protected]>
Co-authored-by: gaobinlong <[email protected]>
Co-authored-by: Rachana Dani <[email protected]>
Co-authored-by: rdani <[email protected]>
Co-authored-by: Peter Zhu <[email protected]>
@zhichao-aws zhichao-aws added the v2.12.0 Issues targeting release v2.12.0 label Nov 23, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 23, 2024
* Microsoft teams (#676)

* Added feature support for microsoft teams webhoo

Signed-off-by: danielkyalo599 <[email protected]>

* Added feature support for microsoft teams webhook ,removed valid webhooks

Signed-off-by: danielkyalo599 <[email protected]>

* Added feature support for Microsoft teams webhook

Signed-off-by: danielkyalo599 <[email protected]>

* Refactored feature support for  ms teams and added unit and integTest

Signed-off-by: danielkyalo599 <[email protected]>

* fix build in core

Signed-off-by: zhichao-aws <[email protected]>

* fix core-spi build

Signed-off-by: zhichao-aws <[email protected]>

* fix notifications main code

Signed-off-by: zhichao-aws <[email protected]>

* fix mappings, add IT

Signed-off-by: zhichao-aws <[email protected]>

* add auto upgrade mapping logic

Signed-off-by: zhichao-aws <[email protected]>

* put load mapping to initialize step

Signed-off-by: zhichao-aws <[email protected]>

* add schema_version field

Signed-off-by: zhichao-aws <[email protected]>

* add integ test

Signed-off-by: zhichao-aws <[email protected]>

* adjust with auto upgrade mapping logic

Signed-off-by: zhichao-aws <[email protected]>

* add bwc

Signed-off-by: zhichao-aws <[email protected]>

* modify bwc

Signed-off-by: zhichao-aws <[email protected]>

* modify bwc

Signed-off-by: zhichao-aws <[email protected]>

* resolve  comments

Signed-off-by: zhichao-aws <[email protected]>

* add license header

Signed-off-by: zhichao-aws <[email protected]>

* fix microsoft teams sample url in IT to adapt url validation

Signed-off-by: zhichao-aws <[email protected]>

---------

Signed-off-by: danielkyalo599 <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Co-authored-by: danielkyalo599 <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Add microsoft teams validation error message (#746)

* add validation failure message for Microsoft Teams

Signed-off-by: zhichao-aws <[email protected]>

* modify integtest

Signed-off-by: zhichao-aws <[email protected]>

---------

Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* onboard system and hidden index (#742)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Updates demo certs used in integ tests (#756)

Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Add 2.10.0 release notes (#755)

* Add 2.10.0 release notes

Signed-off-by: Hailong Cui <[email protected]>

* update release notes

Signed-off-by: Hailong Cui <[email protected]>

* Update opensearch-notifications.release-notes-2.10.0.0.md

Signed-off-by: Hailong Cui <[email protected]>

* fix wrong PR number

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* bump bwc version to 2.11 (#763)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Add 2.11 release notes (#774)

Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Fix integration test failure by allowing direct access to system index warning (#784)

* Fix integration test failure by allowing direct access to system index warning

Signed-off-by: gaobinlong <[email protected]>

* Fix bwc test failure of throwing direct access to system index when getting mapping

Signed-off-by: gaobinlong <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Re-enable detekt

Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0`

Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* bump bwc version to 2.12 (#793)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Update dependency org.json:json to v20231013 (#795)

Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Impove security plugin enabling check (#792)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Add github workflow to auto bump bwc version  (#799)

* Adding bump bwc version github workflow

Signed-off-by: Hailong Cui <[email protected]>

* revert app id

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Replace the TestMailServer to GreenMail server (#801)

* Add 2.11 release notes (#774)

Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: rdani <[email protected]>

* Fix integration test failure by allowing direct access to system index warning (#784)

* Fix integration test failure by allowing direct access to system index warning

Signed-off-by: gaobinlong <[email protected]>

* Fix bwc test failure of throwing direct access to system index when getting mapping

Signed-off-by: gaobinlong <[email protected]>

---------

Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: rdani <[email protected]>

* Replace the TestMailServer to GreenMail server

Signed-off-by: rdani <[email protected]>

* bump bwc version to 2.12 (#793)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: rdani <[email protected]>

* Update dependency org.json:json to v20231013 (#795)

Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: rdani <[email protected]>

* Re-enable detekt (#796)

Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0`

Signed-off-by: Aniruddh <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
Signed-off-by: rdani <[email protected]>

* Add assertion for retrieval of notification

Signed-off-by: rdani <[email protected]>

* Update to stable version

Signed-off-by: rdani <[email protected]>

* Update to stable version

Signed-off-by: rdani <[email protected]>

* Update to suggested version

Signed-off-by: rdani <[email protected]>

---------

Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: rdani <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
Co-authored-by: Yuye Zhu <[email protected]>
Co-authored-by: gaobinlong <[email protected]>
Co-authored-by: rdani <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
Co-authored-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Onboard prod jenkins docker image to github actions (#809)

* Onboard prod jenkins docker image to github actions

Signed-off-by: Peter Zhu <[email protected]>

* Add more

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Added org.apache.logging.log4j:log4j-slf4j-impl to classpath (#791)

* Added slf4j-jdk14.jar to classpath

Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded.
Followed instructions from warning messages that appear.

Signed-off-by: Noir <[email protected]>

* Undid 80fc198

Removed slf4j-jdk14.jar from classpath

Signed-off-by: Aniruddh <[email protected]>

* Added org.apache.logging.log4j:log4j-slf4j-impl to classpath

Signed-off-by: Aniruddh <[email protected]>

---------

Signed-off-by: Noir <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Added Slack webhook URL validation regex

Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL

Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Replaced more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL

Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Replaced even more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL

Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Replace path of mock Slack URL with `sample_slack_url`

Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Remove slackId from domainIds

Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Replace wrongly formatted dummy Slack URL with properly formatted dummy Slack URL

Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Aniruddh <[email protected]>

* Add tests for wrong Slack URLs

Signed-off-by: Aniruddh <[email protected]>

* Add validation tests for Slack URL

Signed-off-by: Aniruddh <[email protected]>

* Format

Signed-off-by: Aniruddh <[email protected]>

* GovSlack apps can use the slack-gov.com domain

Signed-off-by: Aniruddh <[email protected]>

* Add validation for gov-slack.com domain

Signed-off-by: Aniruddh <[email protected]>

---------

Signed-off-by: danielkyalo599 <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: rdani <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Noir <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
Co-authored-by: zhichao-aws <[email protected]>
Co-authored-by: danielkyalo599 <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
Co-authored-by: Darshit Chanpura <[email protected]>
Co-authored-by: Yuye Zhu <[email protected]>
Co-authored-by: gaobinlong <[email protected]>
Co-authored-by: Rachana Dani <[email protected]>
Co-authored-by: rdani <[email protected]>
Co-authored-by: Peter Zhu <[email protected]>
(cherry picked from commit 87109a0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Aug 23, 2024
* Microsoft teams (#676)

* Added feature support for microsoft teams webhoo



* Added feature support for microsoft teams webhook ,removed valid webhooks



* Added feature support for Microsoft teams webhook



* Refactored feature support for  ms teams and added unit and integTest



* fix build in core



* fix core-spi build



* fix notifications main code



* fix mappings, add IT



* add auto upgrade mapping logic



* put load mapping to initialize step



* add schema_version field



* add integ test



* adjust with auto upgrade mapping logic



* add bwc



* modify bwc



* modify bwc



* resolve  comments



* add license header



* fix microsoft teams sample url in IT to adapt url validation



---------






* Add microsoft teams validation error message (#746)

* add validation failure message for Microsoft Teams



* modify integtest



---------




* onboard system and hidden index (#742)




* Updates demo certs used in integ tests (#756)




* Add 2.10.0 release notes (#755)

* Add 2.10.0 release notes



* update release notes



* Update opensearch-notifications.release-notes-2.10.0.0.md



* fix wrong PR number



---------




* bump bwc version to 2.11 (#763)




* Add 2.11 release notes (#774)




* Fix integration test failure by allowing direct access to system index warning (#784)

* Fix integration test failure by allowing direct access to system index warning



* Fix bwc test failure of throwing direct access to system index when getting mapping



---------





* Re-enable detekt

Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0`





* bump bwc version to 2.12 (#793)





* Update dependency org.json:json to v20231013 (#795)





* Impove security plugin enabling check (#792)





* Add github workflow to auto bump bwc version  (#799)

* Adding bump bwc version github workflow



* revert app id



---------





* Replace the TestMailServer to GreenMail server (#801)

* Add 2.11 release notes (#774)




* Fix integration test failure by allowing direct access to system index warning (#784)

* Fix integration test failure by allowing direct access to system index warning



* Fix bwc test failure of throwing direct access to system index when getting mapping



---------




* Replace the TestMailServer to GreenMail server



* bump bwc version to 2.12 (#793)




* Update dependency org.json:json to v20231013 (#795)




* Re-enable detekt (#796)

Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0`





* Add assertion for retrieval of notification



* Update to stable version



* Update to stable version



* Update to suggested version



---------














* Onboard prod jenkins docker image to github actions (#809)

* Onboard prod jenkins docker image to github actions



* Add more



---------





* Added org.apache.logging.log4j:log4j-slf4j-impl to classpath (#791)

* Added slf4j-jdk14.jar to classpath

Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded.
Followed instructions from warning messages that appear.



* Undid 80fc198

Removed slf4j-jdk14.jar from classpath



* Added org.apache.logging.log4j:log4j-slf4j-impl to classpath



---------






* Added Slack webhook URL validation regex




* Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL





* Replaced more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL




* Replaced even more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL




* Replace path of mock Slack URL with `sample_slack_url`




* Remove slackId from domainIds




* Replace wrongly formatted dummy Slack URL with properly formatted dummy Slack URL




* Add tests for wrong Slack URLs



* Add validation tests for Slack URL



* Format



* GovSlack apps can use the slack-gov.com domain



* Add validation for gov-slack.com domain



---------
























(cherry picked from commit 87109a0)

Signed-off-by: danielkyalo599 <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: rdani <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Noir <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: zhichao-aws <[email protected]>
Co-authored-by: danielkyalo599 <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
Co-authored-by: Darshit Chanpura <[email protected]>
Co-authored-by: Yuye Zhu <[email protected]>
Co-authored-by: gaobinlong <[email protected]>
Co-authored-by: Rachana Dani <[email protected]>
Co-authored-by: rdani <[email protected]>
Co-authored-by: Peter Zhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Some slf4j warn message shows in the log file when sending email
5 participants