Skip to content

Commit

Permalink
Re-enable detekt (#796)
Browse files Browse the repository at this point in the history
Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0`

Signed-off-by: Aniruddh <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
  • Loading branch information
Noir01 and Hailong-am authored Oct 18, 2023
1 parent 48e05af commit 0e55d38
Showing 1 changed file with 7 additions and 10 deletions.
17 changes: 7 additions & 10 deletions notifications/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,14 @@ buildscript {
classpath "org.opensearch.gradle:build-tools:${opensearch_version}"
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:${kotlin_version}"
classpath "org.jetbrains.kotlin:kotlin-allopen:${kotlin_version}"
// TODO: enable detekt only when snakeyaml vulnerability is fixed
// classpath "io.gitlab.arturbosch.detekt:detekt-gradle-plugin:1.17.1"
classpath "io.gitlab.arturbosch.detekt:detekt-gradle-plugin:1.23.0"
classpath "org.jacoco:org.jacoco.agent:0.8.7"
}
}

apply plugin: 'base'
apply plugin: 'jacoco'
// TODO: enable detekt only when snakeyaml vulnerability is fixed
//apply plugin: 'io.gitlab.arturbosch.detekt'
apply plugin: 'io.gitlab.arturbosch.detekt'
apply from: 'build-tools/merged-coverage.gradle'

allprojects {
Expand Down Expand Up @@ -100,12 +98,11 @@ task ktlintFormat(type: JavaExec, group: "formatting") {
jvmArgs "--add-opens=java.base/java.lang=ALL-UNNAMED"
}

// TODO: enable detekt only when snakeyaml vulnerability is fixed
//detekt {
// config = files("detekt.yml")
// buildUponDefaultConfig = true
// parallel = true
//}
detekt {
config = files("detekt.yml")
buildUponDefaultConfig = true
parallel = true
}

check.dependsOn ktlint

Expand Down

0 comments on commit 0e55d38

Please sign in to comment.