Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register admin UI as AI models in data administration use case #337

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Register admin UI as AI models in data administration use case #337

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b154d2
Register admin UI as ai models in data administration use case
wanglam Jun 26, 2024
17ac6f7
Fix addNavLinksToGroup not found in chrome service
wanglam Jul 1, 2024
9706be7
Update nav link text
wanglam Jul 3, 2024
5255095
Change text to AI models
wanglam Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion public/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,14 @@
* SPDX-License-Identifier: Apache-2.0
*/

import { AppMountParameters, CoreSetup, CoreStart, Plugin } from '../../../src/core/public';
import { i18n } from '@osd/i18n';
import {
AppMountParameters,
CoreSetup,
CoreStart,
DEFAULT_NAV_GROUPS,
Plugin,
} from '../../../src/core/public';
import {
MlCommonsPluginPluginSetup,
MlCommonsPluginPluginStart,
Expand Down Expand Up @@ -48,6 +55,18 @@ export class MlCommonsPluginPlugin
},
});

core.chrome.navGroup.addNavLinksToGroup(DEFAULT_NAV_GROUPS.dataAdministration, [
{
id: PLUGIN_ID,
category: {
id: 'ai-model',
label: i18n.translate('MLCommonsDashboards.AIModels.Category', {
defaultMessage: 'ai models',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the message say:

Suggested change
defaultMessage: 'ai models',
defaultMessage: 'AI models',

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was using "ai models" in the UX design.
image

@lauralexis Could you help me take a look? Shall we change to AI models?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image UX design updated, already change to AI models

}),
},
},
]);

// Return methods that should be available to other plugins
return {};
}
Expand Down
Loading