Add back model id column #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
==========================================
+ Coverage 80.29% 83.23% +2.93%
==========================================
Files 26 42 +16
Lines 477 650 +173
Branches 109 140 +31
==========================================
+ Hits 383 541 +158
- Misses 67 78 +11
- Partials 27 31 +4 ☔ View full report in Codecov by Sentry. |
raintygao
reviewed
Apr 23, 2024
| { | ||
| field: 'id', | ||
| name: 'Model ID', | ||
| width: '18%', |
There was a problem hiding this comment.
Should we let width self-adaptive or specific?
There was a problem hiding this comment.
Do you mean self-adaptive by model id length? I think it's hard to do that. The percentage column width value will follow by the table width. It will shrink if window size reduced. The model id will be truncated.
ruanyl
approved these changes
Apr 23, 2024
raintygao
approved these changes
Apr 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 6c72ce8)
wanglam
added a commit
that referenced
this pull request
Apr 23, 2024
Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 6c72ce8) Co-authored-by: Lin Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add back model id column to overview page
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.