Binary hamming fix 2.x #2456
Merged
Binary hamming fix 2.x #2456
+559
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace with binary vectors Signed-off-by: Bansi Kasundra <[email protected]>
…ctors Signed-off-by: Bansi Kasundra <[email protected]>
Signed-off-by: Bansi Kasundra <[email protected]>
kasundra07
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas and
0ctopus13prime
as code owners
Signed-off-by: Bansi Kasundra <[email protected]>
VijayanB
approved these changes
Jan 28, 2025
jmazanec15
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the unnecessary type conversion from byte[] to float[] and again float[] to byte for script score on KNN Binary vector using hamming space. This would help bring down the overall query latency.
For details, check #1827 (comment)
Related Issues
Resolves #1827
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.