Fix sequence of NativeMemory/QuantizationState cache test setup/teardown #2387
+4
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: owenhalpert <[email protected]>
owenhalpert
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas and
0ctopus13prime
as code owners
owenhalpert
changed the title
5 tasks
shatejas
approved these changes
Jan 14, 2025
jmazanec15
approved these changes
Jan 14, 2025
Rajrahane
pushed a commit
to Rajrahane/k-NN
that referenced
this pull request
Jan 15, 2025
Signed-off-by: owenhalpert <[email protected]> Signed-off-by: Rajvaibhav Rahane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While looking into my backport PR's test failure I found that the new setUp/tearDown flow conflicts with the existing NativeMemoryCacheTests class cleanup. This is what caused the odd failure. This new revision scopes down the change to the setup/teardown flow and overall keeps things more simple.
Related Issues
#2308
#2390 (manual backport)
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.