-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Faiss commit from 1f42e81 to 0cbc2a8 #2381
Merged
naveentatikonda
merged 1 commit into
opensearch-project:main
from
naveentatikonda:bump_faiss_commit_to_0cbc2a8_
Jan 13, 2025
Merged
Bump Faiss commit from 1f42e81 to 0cbc2a8 #2381
naveentatikonda
merged 1 commit into
opensearch-project:main
from
naveentatikonda:bump_faiss_commit_to_0cbc2a8_
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveentatikonda
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas and
0ctopus13prime
as code owners
January 11, 2025 04:19
@naveentatikonda what changes this new commit is brining in? |
naveentatikonda
force-pushed
the
bump_faiss_commit_to_0cbc2a8_
branch
from
January 12, 2025 05:10
b436aaa
to
17d6fb4
Compare
@navneet1v We are bumping the commit to accelerate Hamming distance calculation using |
@naveentatikonda lets not skip change log for this PR. |
naveentatikonda
force-pushed
the
bump_faiss_commit_to_0cbc2a8_
branch
from
January 13, 2025 06:40
17d6fb4
to
fb0e93a
Compare
navneet1v
reviewed
Jan 13, 2025
Signed-off-by: Naveen Tatikonda <[email protected]>
naveentatikonda
force-pushed
the
bump_faiss_commit_to_0cbc2a8_
branch
from
January 13, 2025 18:25
fb0e93a
to
380ff79
Compare
navneet1v
approved these changes
Jan 13, 2025
jmazanec15
approved these changes
Jan 13, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
Signed-off-by: Naveen Tatikonda <[email protected]> (cherry picked from commit 7991350)
navneet1v
pushed a commit
that referenced
this pull request
Jan 14, 2025
Signed-off-by: Naveen Tatikonda <[email protected]> (cherry picked from commit 7991350) Co-authored-by: Naveen Tatikonda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump Faiss commit from
1f42e81
to0cbc2a8
to include facebookresearch/faiss@0cbc2a8 and facebookresearch/faiss@3beb07bCheck List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.