Fixed a bug that does not get a space type from index setting when it… #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ctopus13prime
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng and
shatejas
as code owners
5 tasks
Vikasht34
approved these changes
Jan 9, 2025
shatejas
reviewed
Jan 9, 2025
src/main/java/org/opensearch/knn/index/engine/SpaceTypeResolver.java
Outdated
Show resolved
Hide resolved
… is empty for compatibility. Signed-off-by: Dooyong Kim <[email protected]>
0ctopus13prime
force-pushed
the
space-type-bug-fix
branch
from
e9b42c0 to
0899552
Compare
|
Looks good |
Vikasht34
approved these changes
Jan 11, 2025
|
@shatejas |
shatejas
approved these changes
Jan 13, 2025
jmazanec15
approved these changes
Jan 13, 2025
0ctopus13prime
added a commit
to 0ctopus13prime/k-NN
that referenced
this pull request
Jan 14, 2025
… is empty for compatibility. (opensearch-project#2374) Signed-off-by: Dooyong Kim <[email protected]> Co-authored-by: Dooyong Kim <[email protected]>
0ctopus13prime
pushed a commit
to 0ctopus13prime/k-NN
that referenced
this pull request
Jan 14, 2025
… is empty for compatibility. (opensearch-project#2374) Signed-off-by: Dooyong Kim <[email protected]> Co-authored-by: Dooyong Kim <[email protected]>
0ctopus13prime
added a commit
that referenced
this pull request
Jan 15, 2025
… is empty for compatibility. (#2374) (#2389) Signed-off-by: Dooyong Kim <[email protected]> Signed-off-by: Doo Yong Kim <[email protected]> Co-authored-by: Dooyong Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue : #2296
This PR is to fix the mapper to acquire the space type value from index setting for legacy case.
It is deprecated, but it is still available to set the space type at index level. But the current logic picks the default L2 metric when it failed to find the one from top level and method causing the score discrepancy. Even cosine similarity metric was configured at index level, it is not being considered in 2.17 because of the bug.
Hence, this PR is to fix the bug to be backward compatibility.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.