bump actions/upload-artifact from 3 to 4

[cwperks]

Description

Recreates this PR previously created by dependabot: #552

Related Issues

Resolves #698

Check List

• New functionality includes testing.
• New functionality has been documented.
• API changes companion pull request created.
• Commits are signed per the DCO using --signoff.
• Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[prudhvigodithi]

Seen something similar in past #556 (comment), since we are using the stage, the compatibility issue is coming from the CI image.

Get-CI-Image-Tag:
    uses: opensearch-project/opensearch-build/.github/workflows/get-ci-image-tag.yml@main
    with:
      product: opensearch

Adding @peterzhuamazon
Thank you

[cwperks]

@dhrubo-os how did ml-commons update this? https://github.com/opensearch-project/ml-commons/blob/5cfdc3ce9aa89d79d0ada175d1a497e1942fd75a/.github/workflows/CI-workflow.yml#L85

I noticed that ML-Commons has failing tests on the main branch (Example). Did you run into the same issue yet or was the new step in the linux workflow not hit yet?

[dhrubo-os]

@dhrubo-os how did ml-commons update this? https://github.com/opensearch-project/ml-commons/blob/5cfdc3ce9aa89d79d0ada175d1a497e1942fd75a/.github/workflows/CI-workflow.yml#L85

I noticed that ML-Commons has failing tests on the main branch (Example). Did you run into the same issue yet or was the new step in the linux workflow not hit yet?

Yeah, we are running into the same issue.

@peterzhuamazon raised a PR.

Most likely we need to follow this.

[prudhvigodithi]

I have a POC PR #700 to move upload-artifact outside of the container, I was able to achieve this with Github https://github.com/actions/cache and works fine as expected.
But again the latest version is actions/cache/save@v4 but I was forced to use actions/cache/save@v3 due to the same GLIBC error. However since now the actions/upload-artifact is moved to a step outside of container I was able to use the actions/upload-artifact@v4. @cwperks can you please check this PR https://github.com/opensearch-project/job-scheduler/pull/700/files, I dont see a big advantage as still we are going with an older version of actions/cache/save@v3.

Thank you
@getsaurabh02 @gaiksaya