Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support query_string for rollup search #438

Closed

Conversation

Angie-Zhang
Copy link
Contributor

Issue #, if available:

Meta Issue: #408
Issue: #320

Description of changes:

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Angie-Zhang Angie-Zhang requested a review from a team August 2, 2022 01:29
@codecov-commenter
Copy link

Codecov Report

Merging #438 (f427fc4) into main (0f0ba16) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Current head f427fc4 differs from pull request most recent head 80afc68. Consider uploading reports for the commit 80afc68 to get more accurate results

@@             Coverage Diff              @@
##               main     #438      +/-   ##
============================================
+ Coverage     75.81%   75.90%   +0.08%     
+ Complexity     2466     2462       -4     
============================================
  Files           313      313              
  Lines         14411    14411              
  Branches       2227     2227              
============================================
+ Hits          10926    10938      +12     
+ Misses         2239     2225      -14     
- Partials       1246     1248       +2     
Impacted Files Coverage Δ
...nt/indexstatemanagement/model/destination/Slack.kt 55.55% <0.00%> (-22.23%) ⬇️
...anagement/indexstatemanagement/model/Transition.kt 63.01% <0.00%> (-2.74%) ⬇️
...management/indexstatemanagement/MetadataService.kt 62.68% <0.00%> (-2.24%) ⬇️
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 68.71% <0.00%> (-0.59%) ⬇️
.../opensearch/indexmanagement/rollup/model/Rollup.kt 85.58% <0.00%> (-0.47%) ⬇️
...arch/indexmanagement/rollup/RollupSearchService.kt 61.11% <0.00%> (ø)
...nsform/action/stop/TransportStopTransformAction.kt 77.77% <0.00%> (ø)
...xmanagement/indexstatemanagement/util/StepUtils.kt 87.64% <0.00%> (+2.24%) ⬆️
...gement/indexstatemanagement/action/ShrinkAction.kt 72.05% <0.00%> (+2.94%) ⬆️
...statemanagement/model/destination/CustomWebhook.kt 95.71% <0.00%> (+28.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@Angie-Zhang Angie-Zhang deleted the query-string-dev branch February 18, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants