Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta issue]: Rollups Enhancements #408

Closed
6 tasks done
praveensameneni opened this issue Jul 11, 2022 · 4 comments
Closed
6 tasks done

[Meta issue]: Rollups Enhancements #408

praveensameneni opened this issue Jul 11, 2022 · 4 comments
Assignees
Labels
enhancement New request

Comments

@praveensameneni
Copy link
Member

praveensameneni commented Jul 11, 2022

Meta issue for Rollups enhancements:

1. Count documents from source index

2. Allow a dynamic target index in ISM Rollups

3. Allow rollup searches to multiple rollup indices if they have the same rollup

4. Allow query_string queries against rollups data

  • Enable searching with query string queries in the rollup interceptor
@downsrob
Copy link
Contributor

For collecting the number of documents from the source index, the index management code base was prepped for a change in core which would make use of the _doc_counts metadata field to allow for seamlessly aggregating summary documents as we do in rollups. This core change did not come, but the change really belongs in core. This issue is open in the core repo here:
opensearch-project/OpenSearch#3712
We should pick this up as the solution to aggregating document counts from summary docs.

@downsrob
Copy link
Contributor

downsrob commented Aug 6, 2022

I have updated the individual issues, but to summarize the progress at the time of the 2.2 release:

  1. Doc counts changes are fully complete
  2. Mustache field templates based on source index name is done. Using an alias as a target index will be targeted for the next release. There are some user experience questions related to that feature which I have commented in the issue.
  3. Searching multiple rollup indices is fully implemented. Integration and unit tests have not yet been added and should be added as soon as possible.
  4. There is an open PR for query string queries, but this PR does not include support for translating field names in the query string or the default field value. It is going to take more investigation to figure out how to best parse and then translate the query string.

@bbarani bbarani removed the v2.2.0 label Oct 20, 2022
@bbarani
Copy link
Member

bbarani commented Oct 20, 2022

@downsrob I have removed 2.2.0 version label. Can you please re-tag this issue with the right version?

@deshsidd
Copy link
Contributor

Query String Query in Rollups completed : #320

@deshsidd deshsidd self-assigned this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New request
Projects
None yet
Development

No branches or pull requests

6 participants