Fixed bugs in history navigation in rollups and transform jobs pages and some UI changes #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kshitij Tandon <[email protected]>
tandonks
requested review from
bowenlan-amzn,
Hailong-am,
RamakrishnaChilaka,
vikasvb90 and
SuZhou-Joe
as code owners
Signed-off-by: Kshitij Tandon <[email protected]>
Signed-off-by: Kshitij Tandon <[email protected]>
tandonks
changed the title
tandonks
changed the title
skumawat2025
reviewed
Sep 3, 2024
public/pages/RollupDetails/containers/RollupDetails/__snapshots__/RollupDetails.test.tsx.snap
Outdated
Show resolved
Hide resolved
skumawat2025
reviewed
Sep 3, 2024
Signed-off-by: Kshitij Tandon <[email protected]>
tandonks
changed the title
|
LGTM. |
Signed-off-by: Kshitij Tandon <[email protected]>
Signed-off-by: Kshitij Tandon <[email protected]>
skumawat2025
reviewed
Sep 4, 2024
| @@ -120,6 +120,7 @@ const CronSchedule = ({ | |||
| let startTimeContent; | |||
| startTimeContent = ( | |||
| <EuiDatePicker | |||
| compressed | |||
There was a problem hiding this comment.
Thanks for adding this @tandonks.
Signed-off-by: Kshitij Tandon <[email protected]>
SuZhou-Joe
approved these changes
Sep 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
…and some UI changes (#1166) * Fixed action button padding and removed plus sign in some pages Signed-off-by: Kshitij Tandon <[email protected]> * Fixed a bug in Transform and Rollup Details pages Signed-off-by: Kshitij Tandon <[email protected]> * Removed some commented code Signed-off-by: Kshitij Tandon <[email protected]> * Retracting couple of changes from previous commits Signed-off-by: Kshitij Tandon <[email protected]> * Fixed spacing between buttons in bottom bar Signed-off-by: Kshitij Tandon <[email protected]> * Added compressed prop to DatePicker in Snapshot Policy Signed-off-by: Kshitij Tandon <[email protected]> * Minor change in previous commit Signed-off-by: Kshitij Tandon <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]> (cherry picked from commit 3c1c7a3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 4, 2024
…and some UI changes (#1166) (#1168) * Fixed action button padding and removed plus sign in some pages * Fixed a bug in Transform and Rollup Details pages * Removed some commented code * Retracting couple of changes from previous commits * Fixed spacing between buttons in bottom bar * Added compressed prop to DatePicker in Snapshot Policy * Minor change in previous commit --------- (cherry picked from commit 3c1c7a3) Signed-off-by: Kshitij Tandon <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
tandonks
added a commit
to tandonks/index-management-dashboards-plugin
that referenced
this pull request
Sep 4, 2024
…and some UI changes (opensearch-project#1166) * Fixed action button padding and removed plus sign in some pages Signed-off-by: Kshitij Tandon <[email protected]> * Fixed a bug in Transform and Rollup Details pages Signed-off-by: Kshitij Tandon <[email protected]> * Removed some commented code Signed-off-by: Kshitij Tandon <[email protected]> * Retracting couple of changes from previous commits Signed-off-by: Kshitij Tandon <[email protected]> * Fixed spacing between buttons in bottom bar Signed-off-by: Kshitij Tandon <[email protected]> * Added compressed prop to DatePicker in Snapshot Policy Signed-off-by: Kshitij Tandon <[email protected]> * Minor change in previous commit Signed-off-by: Kshitij Tandon <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]>
1 task
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 4, 2024
…and some UI changes (#1166) (#1169) * Fixed action button padding and removed plus sign in some pages * Fixed a bug in Transform and Rollup Details pages * Removed some commented code * Retracting couple of changes from previous commits * Fixed spacing between buttons in bottom bar * Added compressed prop to DatePicker in Snapshot Policy * Minor change in previous commit --------- Signed-off-by: Kshitij Tandon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.