Update new header for Alias, Index Templates, Policy Managed Indices, Indexes and Transform Jobs #1124

tandonks · 2024-08-18T07:29:13Z

Description

New Header UI changes for Alias, Indexes, Templates, Transforms and Policy Managed Indexes for ISM dashboard pages

Issues Resolved

[List any issues this PR will resolve]

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Policy Managed Indexes (NewUI)

Policy Managed Indexes (OldUI)

Indexes (NewUI)

Indexes (OldUI)

Index Aliases (NewUI)

Index Aliases (OldUI)

Templates (NewUI)

Templates (OldUI)

Transforms (NewUI)

Transforms (OldUI)

astute-decipher · 2024-08-18T17:34:55Z

public/pages/ChangePolicy/containers/ChangePolicy/ChangePolicy.tsx

-          <h1>Change policy</h1>
-        </EuiTitle>
+    const uiSettings = getUISettings();
+    const useUpdatedUX = uiSettings.get("home:useNewHomePage");


Remove this

astute-decipher · 2024-08-18T17:35:13Z

public/pages/ChangePolicy/containers/ChangePolicy/ChangePolicy.tsx

@@ -192,12 +210,12 @@ export class ChangePolicy extends Component<ChangePolicyProps, ChangePolicyState

        <EuiFlexGroup alignItems="center" justifyContent="flexEnd">
          <EuiFlexItem grow={false}>
-            <EuiButtonEmpty onClick={this.onCancel} data-test-subj="changePolicyCancelButton">
+            <EuiButtonEmpty size={useUpdatedUX ? "s" : "l"} onClick={this.onCancel} data-test-subj="changePolicyCancelButton">


use undefined

astute-decipher · 2024-08-18T17:36:35Z

public/pages/CreateIndex/containers/CreateIndex/CreateIndex.tsx

@@ -45,7 +47,20 @@ export class CreateIndex extends Component<CreateIndexProps> {
  render() {
    const isEdit = this.isEdit;

-    return (
+    const uiSettings = getUISettings();
+    const useUpdatedUX = uiSettings.get("home:useNewHomePage");


remove this

astute-decipher · 2024-08-18T17:36:58Z

public/pages/CreateIndexTemplate/containers/CreateIndexTemplate/CreateIndexTemplate.tsx

+    const uiSettings = getUISettings();
+    const useUpdatedUX = uiSettings.get("home:useNewHomePage");
+
+    return !useUpdatedUX ? (


remove this

astute-decipher · 2024-08-18T17:38:37Z

public/pages/CreateIndexTemplate/containers/TemplateDetail/TemplateDetail.tsx

@@ -192,8 +196,79 @@ const TemplateDetail = (props: TemplateDetailProps, ref: Ref<FieldInstance>) =>
    </EuiFlexItem>
  );

-  return (
-    <>
+  const uiSettings = getUISettings();


Pass it as Props for TemplateDetails

astute-decipher · 2024-08-18T17:40:34Z

public/pages/CreateIndexTemplate/containers/TemplateDetail/TemplateDetail.tsx

+          <>
+            <HeaderControl controls={HeaderRight} setMountPoint={setAppRightControls} />
+          </>
+        ) : null}


Can be modified as. :

{isEdit ? ( <HeaderControl controls={HeaderRight} setMountPoint={setAppRightControls} /> ) : <HeaderControl controls={descriptionData} setMountPoint={setAppDescriptionControls} />}

astute-decipher · 2024-08-18T17:42:45Z

public/pages/Indices/components/IndexControls/IndexControls.tsx

+    const useUpdatedUX = uiSettings.get("home:useNewHomePage");
+
+    return useUpdatedUX ? (
+      <EuiFlexGroup style={{ padding: "0px 5px 16px 5px" }} alignItems="center">


confirm this padding

astute-decipher · 2024-08-18T17:48:25Z

public/pages/Templates/containers/TemplatesActions/index.tsx

+  const uiSettings = getUISettings();
+  const useUpdatedUX = uiSettings.get("home:useNewHomePage");
+
+  const size = useUpdatedUX ? "s" : "m";


Signed-off-by: Kshitij Tandon <[email protected]>

cr: https://code.amazon.com/reviews/CR-143602949 Signed-off-by: Kshitij Tandon <[email protected]>

Signed-off-by: Kshitij Tandon <[email protected]>

SuZhou-Joe · 2024-08-19T10:03:54Z

public/components/ContentPanel/ContentPanelActions.tsx

  <EuiFlexGroup justifyContent="spaceBetween" alignItems="center">
    {actions.map(({ text, buttonProps = {}, flexItemProps = {}, modal = null, children }, index) => {
      let button = children ? (
        children
      ) : (
-        <EuiButton {...buttonProps} data-test-subj={`${text}Button`}>
+        <EuiButton {...buttonProps} data-test-subj={`${text}Button`} size={size ? size : "m"}>


Just size is good enough, m is the default value of EuiButton size I remember.

SuZhou-Joe · 2024-08-19T10:07:47Z

public/pages/ChangePolicy/components/ChangeManagedIndices/ChangeManagedIndices.tsx

@@ -109,6 +109,7 @@ export default class ChangeManagedIndices extends Component<ChangeManagedIndices
              // @ts-ignore
              onChange={this.props.onChangeManagedIndices}
              onSearchChange={this.onManagedIndexSearchChange}
+              compressed={useUpdatedUX ? true : false}


Suggested change

compressed={useUpdatedUX ? true : false}

compressed={useUpdatedUX ? true : undefined}

undefined is preferred, and i just feel that it is totally OK to use a compressed ComboBox no matter the toggle is on or off, Or it can be a huge maintenance effort.

SuZhou-Joe · 2024-08-19T10:10:04Z

@tandonks Please split the PR into several smaller PRs next time. It's a big pressure for maintainers to review such a huge PR.

opensearch-trigger-bot · 2024-08-20T08:55:55Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/index-management-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/index-management-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport/backport-1124-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 da229f8f7f08e0acc9094aa51c6bd407db295e60
# Push it to GitHub
git push --set-upstream origin backport/backport-1124-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/index-management-dashboards-plugin/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1124-to-2.x.

… Indexes and Transform Jobs (opensearch-project#1124) * wip: changes for new ui Signed-off-by: Kshitij Tandon <[email protected]> * New UI changes Signed-off-by: Kshitij Tandon <[email protected]> * Header Changes Signed-off-by: Kshitij Tandon <[email protected]> * New UI changes Signed-off-by: Kshitij Tandon <[email protected]> * UTs handel Signed-off-by: Kshitij Tandon <[email protected]> * Header UI changes cr: https://code.amazon.com/reviews/CR-143602949 Signed-off-by: Kshitij Tandon <[email protected]> * Updated Change Policy Page Signed-off-by: Kshitij Tandon <[email protected]> * Fixed bug in alias for new UI Signed-off-by: Kshitij Tandon <[email protected]> * Fixing a few bugs and addressing comments Signed-off-by: Kshitij Tandon <[email protected]> * Fixing a few bugs in old UI Signed-off-by: Kshitij Tandon <[email protected]> --------- Signed-off-by: Kshitij Tandon <[email protected]>

… Indexes and Transform Jobs (#1124) (#1137) * wip: changes for new ui * New UI changes * Header Changes * New UI changes * UTs handel * Header UI changes cr: https://code.amazon.com/reviews/CR-143602949 * Updated Change Policy Page * Fixed bug in alias for new UI * Fixing a few bugs and addressing comments * Fixing a few bugs in old UI --------- Signed-off-by: Kshitij Tandon <[email protected]>

tandonks requested review from amsiglan, AWSHurneyt, bowenlan-amzn, getsaurabh02, praveensameneni, xluo-aws, gaobinlong, Hailong-am, SuZhou-Joe, lezzago, sbcd90, eirsep, r1walz and vikasvb90 as code owners August 18, 2024 07:29

astute-decipher reviewed Aug 18, 2024

View reviewed changes

tandonks force-pushed the newUIHeader branch 2 times, most recently from 0161288 to e05899f Compare August 19, 2024 07:55

tandonks added 6 commits August 19, 2024 17:06

wip: changes for new ui

5620c30

Signed-off-by: Kshitij Tandon <[email protected]>

New UI changes

5a87ced

Signed-off-by: Kshitij Tandon <[email protected]>

Header Changes

892ece2

Signed-off-by: Kshitij Tandon <[email protected]>

New UI changes

133c84b

Signed-off-by: Kshitij Tandon <[email protected]>

UTs handel

05a5ee5

Signed-off-by: Kshitij Tandon <[email protected]>

Header UI changes

f795539

cr: https://code.amazon.com/reviews/CR-143602949 Signed-off-by: Kshitij Tandon <[email protected]>

tandonks added 4 commits August 19, 2024 17:06

Updated Change Policy Page

4eac94d

Signed-off-by: Kshitij Tandon <[email protected]>

Fixed bug in alias for new UI

5f3cacd

Signed-off-by: Kshitij Tandon <[email protected]>

Fixing a few bugs and addressing comments

b7606e0

Signed-off-by: Kshitij Tandon <[email protected]>

Fixing a few bugs in old UI

1e6df0b

Signed-off-by: Kshitij Tandon <[email protected]>

SuZhou-Joe force-pushed the newUIHeader branch from e05899f to 1e6df0b Compare August 19, 2024 09:06

SuZhou-Joe added backport 2.x v2.17.0 labels Aug 19, 2024

SuZhou-Joe reviewed Aug 19, 2024

View reviewed changes

SuZhou-Joe approved these changes Aug 19, 2024

View reviewed changes

SuZhou-Joe merged commit da229f8 into opensearch-project:main Aug 20, 2024
13 checks passed

opensearch-trigger-bot bot added the backport-failed label Aug 20, 2024

tandonks mentioned this pull request Aug 20, 2024

Bug fixes for Policy Managed Indices and Indexes pages #1134

Closed

1 task

tandonks mentioned this pull request Aug 20, 2024

(Backport 2.x) Update new header for Alias, Index Templates, Policy Managed Indices,… #1137

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update new header for Alias, Index Templates, Policy Managed Indices, Indexes and Transform Jobs #1124

Update new header for Alias, Index Templates, Policy Managed Indices, Indexes and Transform Jobs #1124

tandonks commented Aug 18, 2024

astute-decipher Aug 18, 2024

astute-decipher Aug 18, 2024

astute-decipher Aug 18, 2024

astute-decipher Aug 18, 2024

astute-decipher Aug 18, 2024

astute-decipher Aug 18, 2024

astute-decipher Aug 18, 2024

astute-decipher Aug 18, 2024

SuZhou-Joe Aug 19, 2024 •

edited

Loading

SuZhou-Joe Aug 19, 2024 •

edited

Loading

SuZhou-Joe commented Aug 19, 2024

opensearch-trigger-bot bot commented Aug 20, 2024

	compressed={useUpdatedUX ? true : false}
	compressed={useUpdatedUX ? true : undefined}

Update new header for Alias, Index Templates, Policy Managed Indices, Indexes and Transform Jobs #1124

Update new header for Alias, Index Templates, Policy Managed Indices, Indexes and Transform Jobs #1124

Conversation

tandonks commented Aug 18, 2024

Description

Issues Resolved

Check List

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SuZhou-Joe Aug 19, 2024 • edited Loading

Choose a reason for hiding this comment

SuZhou-Joe Aug 19, 2024 • edited Loading

Choose a reason for hiding this comment

SuZhou-Joe commented Aug 19, 2024

opensearch-trigger-bot bot commented Aug 20, 2024

SuZhou-Joe Aug 19, 2024 •

edited

Loading

SuZhou-Joe Aug 19, 2024 •

edited

Loading