Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the security audit system index from getting deleted to fix the 2.10 integ tests failures #430

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

navneet1v
Copy link
Collaborator

@navneet1v navneet1v commented Sep 12, 2023

Description

Removing the security audit system index from getting deleted to fix the 2.10 integ tests failures

This is a temporary fix. Ideally we should delete the index from the test where it is getting created. Currently due to short time I cannot do that change as there are many reference of createIndex. Will fix this code starting from main branch and then backport to 2.x

Issues Resolved

#428

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@navneet1v navneet1v added backport 2.x Backport PR to 2.x branch skip-changelog v2.10.0 Issues targeting release v2.10.0 labels Sep 12, 2023
@navneet1v navneet1v added integ-test-failure Integration test failures and removed backport 2.x Backport PR to 2.x branch labels Sep 12, 2023
…the 2.10 integ tests failures

Signed-off-by: Navneet Verma <[email protected]>
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #430 (9aa1170) into 2.10 (9937b18) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               2.10     #430   +/-   ##
=========================================
  Coverage     88.59%   88.59%           
+ Complexity      753      752    -1     
=========================================
  Files            92       92           
  Lines          2717     2717           
  Branches        221      221           
=========================================
  Hits           2407     2407           
  Misses          230      230           
  Partials         80       80           

see 2 files with indirect coverage changes

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! THanks

@navneet1v navneet1v merged commit a3da222 into opensearch-project:2.10 Sep 12, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integ-test-failure Integration test failures skip-changelog v2.10.0 Issues targeting release v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants