-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created release notes for 2.10 release #396
Conversation
Compatible with OpenSearch 2.10.0 | ||
|
||
### Features | ||
* IP2Geo processor implementation ([#362](https://github.com/opensearch-project/geospatial/pull/362)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have better naming for this. Impact does not show up. @heemin32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo, release log is not a place where impact can be seen.
@@ -12,7 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
### Maintenance | |||
### Refactoring | |||
|
|||
## [Unreleased 2.x](https://github.com/opensearch-project/geospatial/compare/2.9...2.x) | |||
## [Unreleased 2.x](https://github.com/opensearch-project/geospatial/compare/2.10...2.x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## [Unreleased 2.x](https://github.com/opensearch-project/geospatial/compare/2.10...2.x) | |
## [Unreleased 2.x](https://github.com/opensearch-project/geospatial/compare/2.11...2.x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the code freeze is not done, I am keeping these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plus 2.11 is not ready. I don't think so we should make this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. You are right here.. It should be 2.10...2.x.
@@ -12,7 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
### Maintenance | |||
### Refactoring | |||
|
|||
## [Unreleased 2.x](https://github.com/opensearch-project/geospatial/compare/2.9...2.x) | |||
## [Unreleased 2.x](https://github.com/opensearch-project/geospatial/compare/2.10...2.x) | |||
### Features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to delete all logs from here when you move them to release note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the code freeze is not done, I am keeping these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted.
Signed-off-by: Navneet Verma <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #396 +/- ##
============================================
+ Coverage 88.47% 88.70% +0.22%
- Complexity 750 754 +4
============================================
Files 92 92
Lines 2717 2717
Branches 221 221
============================================
+ Hits 2404 2410 +6
+ Misses 230 228 -2
+ Partials 83 79 -4 |
Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 8d2a327)
Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 8d2a327)
Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 8d2a327) Co-authored-by: Navneet Verma <[email protected]>
Signed-off-by: Navneet Verma <[email protected]> (cherry picked from commit 8d2a327) Co-authored-by: Navneet Verma <[email protected]>
Description
Created release notes for 2.10 release
Issues Resolved
#357
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.