add word delimiter graph token filter docs #8454 #8468
Conversation
Signed-off-by: Anton Rubin <[email protected]>
AntonEliatra
requested review from
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
|
@udabhas @varun-lodaya Please provide tech review approval to move this PR forward in the documentation process. Please review this week or provide a peer who can review it. Thank you. |
vagimeli
added
3 - Tech review
Signed-off-by: Anton Rubin <[email protected]>
kolchfa-aws
added
5 - Editorial review
Signed-off-by: Fanit Kolchina <[email protected]>
There was a problem hiding this comment.
@kolchfa-aws Please see my comments and changes and let me know if you have any questions. Thanks!
| | Remove leading or trailing delimiters | Removes delimiters at the start or end of tokens. | `Z99++'Decoder'`| `Z99`, `Decoder` | | ||
| | Split tokens at letter case transitions | Splits tokens when there is a transition between uppercase and lowercase letters. | `OpenSearch` | `Open`, `Search` | | ||
| | Split tokens at letter-number transitions | Splits tokens when there is a transition between letters and numbers. | `T1000` | `T`, `1000` | | ||
| | Remove the English possessive ('s) | Removes the possessive ('s) from the end of tokens. | `John's` | `John` | |
There was a problem hiding this comment.
I would argue that the Action and Description columns here are redundant in providing the same information with slightly different phrasing. Are both necessary?
| To illustrate the filter differences, consider the input text `Pro-XT500`. | ||
|
|
||
| <!-- vale off--> | ||
| ### word_delimiter_graph |
There was a problem hiding this comment.
Same comment re: underscores
| - `XT500` (position 2) | ||
| - `ProXT500` (position 1, `positionLength`: 2) | ||
|
|
||
| The `positionLength` attribute ensures a valid graph for advanced queries. |
There was a problem hiding this comment.
"ensures the production of a valid graph to be used in advanced queries"?
| The `positionLength` attribute ensures a valid graph for advanced queries. | ||
|
|
||
| <!-- vale off--> | ||
| ### word_delimiter |
There was a problem hiding this comment.
Same comment re: underscores
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
* add word delimiter graph token filter docs #8454 Signed-off-by: Anton Rubin <[email protected]> * updating parameter table Signed-off-by: Anton Rubin <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Editorial comments Signed-off-by: Fanit Kolchina <[email protected]> * More merge conflicts Signed-off-by: Fanit Kolchina <[email protected]> * typo fix Signed-off-by: Fanit Kolchina <[email protected]> --------- Signed-off-by: Anton Rubin <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> (cherry picked from commit 3f756d2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AntonEliatra
deleted the
adding-word_delimiter_graph-token-filter-docs
branch
Description
add word delimiter graph token filter docs
Issues Resolved
Closes #8454
Version
all
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.